From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Marc Zyngier <maz@kernel.org>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-gpio@vger.kernel.org, Biju Das <biju.das.au@gmail.com>
Subject: Re: [PATCH 1/2] pinctrl: renesas: rzg2l: Make reverse order of enable() for disable()
Date: Mon, 18 Sep 2023 14:54:02 +0200 [thread overview]
Message-ID: <CAMuHMdV_eyPSJ26S5KZoHsLdr92h0xmkPjWbUpwpevS0oeMUXQ@mail.gmail.com> (raw)
In-Reply-To: <20230918123355.262115-2-biju.das.jz@bp.renesas.com>
On Mon, Sep 18, 2023 at 2:34 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> We usually do reverse order of enable() for disable(). Currently, the
> ordering of irq_chip_disable_parent() is not correct in
> rzg2l_gpio_irq_disable(). Fix the incorrect order.
>
> Fixes: db2e5f21a48e ("pinctrl: renesas: pinctrl-rzg2l: Add IRQ domain to handle GPIO interrupt")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-pinctrl-for-v6.7.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2023-09-18 12:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 12:33 [PATCH 0/2] Fix for GPIO interrupts Biju Das
2023-09-18 12:33 ` [PATCH 1/2] pinctrl: renesas: rzg2l: Make reverse order of enable() for disable() Biju Das
2023-09-18 12:54 ` Geert Uytterhoeven [this message]
2023-09-18 12:33 ` [PATCH 2/2] pinctrl: renesas: rzg2l: Enable noise filter for GPIO interrupt input Biju Das
2023-09-18 12:57 ` Geert Uytterhoeven
2023-09-18 13:18 ` Biju Das
2023-09-18 13:25 ` Geert Uytterhoeven
2023-09-18 16:49 ` Biju Das
2023-09-20 9:20 ` Biju Das
2023-09-20 12:20 ` Linus Walleij
2023-09-20 12:37 ` Biju Das
2023-09-20 13:54 ` Linus Walleij
2023-09-20 14:06 ` Biju Das
2023-09-25 13:19 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdV_eyPSJ26S5KZoHsLdr92h0xmkPjWbUpwpevS0oeMUXQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maz@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).