From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2E76C31E40 for ; Tue, 6 Aug 2019 09:23:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AFFAA20880 for ; Tue, 6 Aug 2019 09:23:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732290AbfHFJXx (ORCPT ); Tue, 6 Aug 2019 05:23:53 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:36237 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730068AbfHFJXx (ORCPT ); Tue, 6 Aug 2019 05:23:53 -0400 Received: by mail-ot1-f66.google.com with SMTP id r6so90786686oti.3; Tue, 06 Aug 2019 02:23:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UeKI+wyGIyCm+Z7vX+Uc5wPRZnjQXw15qspoovmCKP4=; b=ZsCUE6QXdyLnc7DYO13z3zwTTdLLc49mvH6lqP3d98zuS/qfp7PYMvOrGLdGD386FK tbAb5ZGvU/UEMaBbBhSYDAU23z/84MIoUXFflyDRl8tVouZoP08coElxFvNGW9Kgrt0M zkQjpIBDqLtsod6dNfxuz9OzjAwX8gQhJXRkcQj9zVBUOoVW1Y5p17YxmNOSg+6tL6Pi v93GJ62V4RoSmrtVtPr1lDwFr/XOMMU9f7Pl+1b08pS105woAQxfBlv7HnunZN6Kg2c4 Xpdf49XzxJv1ycO0yepfZdrDonD6IXGBeuzc4nxOuoL2MGeaqQcjCbSMbFADCMM60fxw 3jfg== X-Gm-Message-State: APjAAAXj0zBbGgd3dttqvqyfvVKbuyaVXufKr5yUUDVMAowzDvgwl1YC 88o033Z3D+2vSJOdRkJKxRjnlWsImaJHUFEDbKM= X-Google-Smtp-Source: APXvYqzoue7LKiVS/fp2yo6a8EkRmr9Vdba6hiJplbafhOoXjkmNz+1Zf6SN7RotjA7UU2od04sn0L2mqC8LAWcPnsY= X-Received: by 2002:a9d:529:: with SMTP id 38mr2294075otw.145.1565083432454; Tue, 06 Aug 2019 02:23:52 -0700 (PDT) MIME-Version: 1.0 References: <1562576868-8124-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1562576868-8124-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> In-Reply-To: <1562576868-8124-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> From: Geert Uytterhoeven Date: Tue, 6 Aug 2019 11:23:41 +0200 Message-ID: Subject: Re: [PATCH RFC 2/7] pinctrl: sh-pfc: remove incomplete flag "cfg->type" To: Yoshihiro Shimoda Cc: Linus Walleij , Geert Uytterhoeven , Thierry Reding , Rob Herring , Mark Rutland , "open list:GPIO SUBSYSTEM" , Linux PWM List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Shimoda-san, On Mon, Jul 8, 2019 at 11:08 AM Yoshihiro Shimoda wrote: > The old commit c58d9c1b26e3 ("sh-pfc: Implement generic pinconf > support") broke the cfg->type flag to PINMUX_TYPE_FUNCTION because > sh_pfc_pinconf_set() didn't call sh_pfc_reconfig_pin(). > Now if we fix the cfg->type condition, it gets worse because: > - Some drivers might be deferred so that .set_mux() will be called > multiple times. > - In such the case, the sh-pfc driver returns -EBUSY even if > the group is the same, and then that driver fails to probe. > > Since the pinctrl subsystem already has such conditions according > to @set_mux and @gpio_request_enable, this patch just remove > the incomplete flag from sh-pfc/pinctrl.c. Do we need to set sh_pfc_pinmux_ops.strict = true? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds