From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 0/7] ARM: shmobile: Move gpio ranges from C code to DT Date: Thu, 16 Jul 2015 11:06:06 +0200 Message-ID: References: <1435650327-2542-1-git-send-email-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Linus Walleij Cc: Geert Uytterhoeven , Alexandre Courbot , Laurent Pinchart , Simon Horman , Magnus Damm , Maxime Ripard , Boris Brezillon , Benoit Parrot , "linux-gpio@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-gpio@vger.kernel.org Hi Linus, On Thu, Jul 16, 2015 at 11:00 AM, Linus Walleij wrote: > On Tue, Jun 30, 2015 at 9:45 AM, Geert Uytterhoeven > wrote: >> This patch series moves the setup of the GPIO-PFC pin mapping for >> Renesas PFC/GPIO combos from C code to DT, and does some cleanups. >> The move to DT is needed to make the GPIO hogging mechanism work, cfr. >> the discussion following "[PATCH] [RFC] gpio: Retry deferred GPIO >> hogging on pin range change" (https://lkml.org/lkml/2015/6/16/455). >> >> The series consists of 3 parts: >> a. Patches 1-3 add the missing "gpio-ranges" properties to the dtsi >> files for all affected SoCs, >> b. Patch 4 disables the C code to set up the mapping on DT platforms >> (it's still needed on SH or ARM-legacy), >> c. Patches 5-7 do a few more cleanups in the sh-pfc gpio code. >> >> Dependencies: >> - This series applies against next-next-20150630. >> - Part a must go in first, to avoid regressions. >> In addition, it's a prerequisite for "ARM: shmobile: armadillo800eva >> dts: Add pinctrl and gpio-hog for lcdc0", which has been queued up >> already in Simon's dt-for-v4.3 branch. Perhaps it can still be >> reordered? >> - While I didn't notice any bad behavior by having part a only, part b >> should go in immediately after part a. Hence I think it's best if >> Simon can take this one, too. >> - Part c is independent (it doesn't touch the same code), so it can go >> in before or after the other parts, or in parallel. >> >> Thanks for applying! >> >> Geert Uytterhoeven (7): >> ARM: shmobile: r8a73a4 dtsi: Add missing "gpio-ranges" to gpio node >> ARM: shmobile: r8a7740 dtsi: Add missing "gpio-ranges" to gpio node >> ARM: shmobile: sh73a0 dtsi: Add missing "gpio-ranges" to gpio node >> pinctrl: sh-pfc: Stop calling gpiochip_add_pin_range() on DT platforms >> pinctrl: sh-pfc: Remove empty gpio_function_free() >> pinctrl: sh-pfc: Move sh_pfc_add_gpiochip() up >> pinctrl: sh-pfc: Confine legacy function GPIOs to SH > > I'm happy of shmobile people are happy. Laurent was mostly worried about the phandle in the "gpio-ranges" property pointing to the gpio/pfc combo node itself. Do you see any issues with that? As there were comments on some of the patches, I have to resend this series anyway... > Acked-by: Linus Walleij Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds