From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH] pinctrl: sh-pfc: Rework PFC GPIO support
Date: Mon, 15 Feb 2016 16:37:23 +0100 [thread overview]
Message-ID: <CAMuHMdW7SW2x6WYCjezFZ9M_7sDHTOrSL0XbH6GkrLbatO_Xew@mail.gmail.com> (raw)
In-Reply-To: <5596419.W3vqRvx1Kq@avalon>
On Mon, Feb 15, 2016 at 1:55 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>> --- 0001/drivers/pinctrl/sh-pfc/Makefile
>> +++ work/drivers/pinctrl/sh-pfc/Makefile 2016-02-15 19:56:50.720513000
> +0900
>> @@ -1,11 +1,8 @@
>> sh-pfc-objs = core.o pinctrl.o
>> -ifeq ($(CONFIG_GPIO_SH_PFC),y)
>> -sh-pfc-objs += gpio.o
>> -endif
>> obj-$(CONFIG_PINCTRL_SH_PFC) += sh-pfc.o
>> obj-$(CONFIG_PINCTRL_PFC_EMEV2) += pfc-emev2.o
>> -obj-$(CONFIG_PINCTRL_PFC_R8A73A4) += pfc-r8a73a4.o
>> -obj-$(CONFIG_PINCTRL_PFC_R8A7740) += pfc-r8a7740.o
>> +obj-$(CONFIG_PINCTRL_PFC_R8A73A4) += pfc-r8a73a4.o gpio.o
>> +obj-$(CONFIG_PINCTRL_PFC_R8A7740) += pfc-r8a7740.o gpio.o
>
> Instead of duplicating gpio.o for every PFC entry that uses it, how about
> keeping it above and just using CONFIG_PINCTRL_SH_PFC_GPIO in the ifeq ?
Or not using the ifeq, but using
obj-$(CONFIG_PINCTRL_SH_PFC_GPIO) += gpio.o
instead?
Is there any specific reason for the existence of the sh-pfc-objs intermediate?
It's not like we can/want to have a modular pinctrl driver...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2016-02-15 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 12:04 [PATCH] pinctrl: sh-pfc: Rework PFC GPIO support Magnus Damm
2016-02-15 12:55 ` Laurent Pinchart
2016-02-15 15:37 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdW7SW2x6WYCjezFZ9M_7sDHTOrSL0XbH6GkrLbatO_Xew@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).