From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] pinctrl: sh-pfc: Rework PFC GPIO support Date: Mon, 15 Feb 2016 16:37:23 +0100 Message-ID: References: <20160215120438.24670.15402.sendpatchset@little-apple> <5596419.W3vqRvx1Kq@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <5596419.W3vqRvx1Kq@avalon> Sender: linux-renesas-soc-owner@vger.kernel.org To: Laurent Pinchart Cc: Magnus Damm , linux-renesas-soc@vger.kernel.org, Linus Walleij , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Simon Horman List-Id: linux-gpio@vger.kernel.org On Mon, Feb 15, 2016 at 1:55 PM, Laurent Pinchart wrote: >> --- 0001/drivers/pinctrl/sh-pfc/Makefile >> +++ work/drivers/pinctrl/sh-pfc/Makefile 2016-02-15 19:56:50.720513000 > +0900 >> @@ -1,11 +1,8 @@ >> sh-pfc-objs = core.o pinctrl.o >> -ifeq ($(CONFIG_GPIO_SH_PFC),y) >> -sh-pfc-objs += gpio.o >> -endif >> obj-$(CONFIG_PINCTRL_SH_PFC) += sh-pfc.o >> obj-$(CONFIG_PINCTRL_PFC_EMEV2) += pfc-emev2.o >> -obj-$(CONFIG_PINCTRL_PFC_R8A73A4) += pfc-r8a73a4.o >> -obj-$(CONFIG_PINCTRL_PFC_R8A7740) += pfc-r8a7740.o >> +obj-$(CONFIG_PINCTRL_PFC_R8A73A4) += pfc-r8a73a4.o gpio.o >> +obj-$(CONFIG_PINCTRL_PFC_R8A7740) += pfc-r8a7740.o gpio.o > > Instead of duplicating gpio.o for every PFC entry that uses it, how about > keeping it above and just using CONFIG_PINCTRL_SH_PFC_GPIO in the ifeq ? Or not using the ifeq, but using obj-$(CONFIG_PINCTRL_SH_PFC_GPIO) += gpio.o instead? Is there any specific reason for the existence of the sh-pfc-objs intermediate? It's not like we can/want to have a modular pinctrl driver... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds