From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Linus Walleij <linus.walleij@linaro.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: drivers/pinctrl/sh-pfc/pfc-sh7734.c multiple define of TCLK1_B
Date: Thu, 17 Oct 2019 15:14:57 +0200 [thread overview]
Message-ID: <CAMuHMdWMbQeFciY-wet0onMrGOCsB+PrTs03Nf=TdjLiaFsnKg@mail.gmail.com> (raw)
In-Reply-To: <1e48cafb-6ec5-0573-4829-03e36f9d3d82@codethink.co.uk>
Hi Ben,
On Thu, Oct 17, 2019 at 1:54 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> drivers/pinctrl/sh-pfc/pfc-sh7734.c hsa TCLK1_B defined twice.
> Not sure how to fix, so reporting it here:
>
> 1453 GPIO_FN(RD_WR), GPIO_FN(TCLK1_B),
> 1454 GPIO_FN(EX_WAIT0), GPIO_FN(TCLK1_B),
Thanks, nice catch!
Looks like (a) someone accidentally jumped to the wrong row in the
datasheet when entering this, and (b) we need more runtime checks to
catch bugs like this.
Will fix...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2019-10-17 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 11:54 drivers/pinctrl/sh-pfc/pfc-sh7734.c multiple define of TCLK1_B Ben Dooks
2019-10-17 13:14 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWMbQeFciY-wet0onMrGOCsB+PrTs03Nf=TdjLiaFsnKg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=ben.dooks@codethink.co.uk \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).