From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B07FA372A for ; Thu, 17 Oct 2019 13:15:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6034C20640 for ; Thu, 17 Oct 2019 13:15:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394410AbfJQNPJ (ORCPT ); Thu, 17 Oct 2019 09:15:09 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:44279 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394358AbfJQNPJ (ORCPT ); Thu, 17 Oct 2019 09:15:09 -0400 Received: by mail-ot1-f66.google.com with SMTP id 21so1805133otj.11; Thu, 17 Oct 2019 06:15:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X4y1bL0W15R+iE+SZario6x1aoorMFx/lA03Hqcj+uo=; b=XjClrDWNDoaEXM8jCzjqpU7bb2QHSY1Wr6yi813YTp4ULQQ7Pt4ZhSbzAt2RR1y3RG KaKZm4RQz+9hJbZU1dUjEWaQpt7XCRr7lvjsDHXy7e6d7TEsNDmZ852T/8Q7dMSLNJNz xxwWW0gQJuCTX+X/vcYKoIHPBzsBiBX0h33iLH5ZecWP0g/O51n9Qfs/GHJGw13hYp3x 1f0mme5exwofv236ZHhr9Qj4qMTfBfcEX21BUYryC1pY3sS5vFRWXdGpYm+nmazMWHKs tYiK9PXkvcFSFLC+c7cJUmi3C5CBTtrCGtND6HHdZRINfidTc6OqvMyxZYWcaXvTc2HT sxzQ== X-Gm-Message-State: APjAAAUAhVeRdlUvonNz2r3WsGU+TMDJauai94bBViQD0B+PTJjdPu18 sVtCtdbC8na1DAcDzyODZa2I2Uz5ZNE0ZrZflLo= X-Google-Smtp-Source: APXvYqx6Cyj0duUJOmyaICT1oznRv0AsWMh3/W9MVZ9kCrwp9V1GSyE7je5R0ohOloX8VfE95wNZLLERLoGqQy+zYsU= X-Received: by 2002:a9d:7345:: with SMTP id l5mr3037382otk.39.1571318108713; Thu, 17 Oct 2019 06:15:08 -0700 (PDT) MIME-Version: 1.0 References: <1e48cafb-6ec5-0573-4829-03e36f9d3d82@codethink.co.uk> In-Reply-To: <1e48cafb-6ec5-0573-4829-03e36f9d3d82@codethink.co.uk> From: Geert Uytterhoeven Date: Thu, 17 Oct 2019 15:14:57 +0200 Message-ID: Subject: Re: drivers/pinctrl/sh-pfc/pfc-sh7734.c multiple define of TCLK1_B To: Ben Dooks Cc: Geert Uytterhoeven , Linus Walleij , Linux-Renesas , "linux-gpio@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Ben, On Thu, Oct 17, 2019 at 1:54 PM Ben Dooks wrote: > drivers/pinctrl/sh-pfc/pfc-sh7734.c hsa TCLK1_B defined twice. > Not sure how to fix, so reporting it here: > > 1453 GPIO_FN(RD_WR), GPIO_FN(TCLK1_B), > 1454 GPIO_FN(EX_WAIT0), GPIO_FN(TCLK1_B), Thanks, nice catch! Looks like (a) someone accidentally jumped to the wrong row in the datasheet when entering this, and (b) we need more runtime checks to catch bugs like this. Will fix... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds