Re: [pinctrl:devel 16/46] drivers/pinctrl/bcm/pinctrl-bcm2835.c:995:10: error: incompatible types when assigning to type 'volatile struct SHIFTER' from type 'unsigned int'

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Michael,

On Wed, Aug 7, 2019 at 12:41 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
> could be renamed shifter_st, I suppose. Only used in
> arch/m68k/atari/config.c and drivers/video/fbdev/atafb.c.

Yeah, exactly my thought.

> On 6/08/19 7:33 PM, Geert Uytterhoeven wrote:
> > CC linux-m68k (shifter too generic a name?)
> >
> > On Tue, Aug 6, 2019 at 5:00 AM kbuild test robot <lkp@intel.com> wrote:
> >> tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
> >> head:   d55b7fdd58ac12e76ef65979af4a13b9c15fc00d
> >> commit: e38a9a437fb93ddafab5030165e4c6a3a5021669 [16/46] pinctrl: bcm2835: Add support for BCM2711 pull-up functionality
> >> config: m68k-allmodconfig (attached as .config)
> >> compiler: m68k-linux-gcc (GCC) 7.4.0
> >> reproduce:
> >>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >>          chmod +x ~/bin/make.cross
> >>          git checkout e38a9a437fb93ddafab5030165e4c6a3a5021669
> >>          # save the attached .config to linux build tree
> >>          GCC_VERSION=7.4.0 make.cross ARCH=m68k
> >>
> >> If you fix the issue, kindly add following tag
> >> Reported-by: kbuild test robot <lkp@intel.com>
> >>
> >> All error/warnings (new ones prefixed by >>):
> >>
> >>     In file included from arch/m68k/include/asm/io_mm.h:32:0,
> >>                      from arch/m68k/include/asm/io.h:8,
> >>                      from include/linux/io.h:13,
> >>                      from include/linux/irq.h:20,
> >>                      from include/linux/gpio/driver.h:7,
> >>                      from drivers/pinctrl/bcm/pinctrl-bcm2835.c:17:
> >>     drivers/pinctrl/bcm/pinctrl-bcm2835.c: In function 'bcm2711_pull_config_set':
> >>>> arch/m68k/include/asm/atarihw.h:190:22: error: expected identifier or '(' before 'volatile'
> >>      # define shifter ((*(volatile struct SHIFTER *)SHF_BAS))
> >>                           ^
> >>>> drivers/pinctrl/bcm/pinctrl-bcm2835.c:990:6: note: in expansion of macro 'shifter'
> >>       u32 shifter;

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds