From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D7ACC43217 for ; Wed, 15 Dec 2021 10:28:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236652AbhLOK2s (ORCPT ); Wed, 15 Dec 2021 05:28:48 -0500 Received: from mail-ua1-f49.google.com ([209.85.222.49]:34502 "EHLO mail-ua1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231710AbhLOK2r (ORCPT ); Wed, 15 Dec 2021 05:28:47 -0500 Received: by mail-ua1-f49.google.com with SMTP id u40so6890059uad.1; Wed, 15 Dec 2021 02:28:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6KatagByVh+i+7U2cQTugmti3xcd82C2QfCSX1Fy8Jo=; b=ZdSXZmf2lY0qFDYqOx3eNuTs5WT7NOc6ukNoEOMkaxZ3NNhCpjouW0yF1pkoFljy1w HUSS2IR71ynLU9QlZ+vceOeosIVH98QKlmfMF5TFoWdN+FaaBnjoHI3XHLineo26rzcE L0vF8a6M1a/3QqyO1XXl4iReb6AAPWS7DIgPCyJaoblQI5jz5UDBrQcdx04SU9xZb2QR MFBHNN2oSD17oX/fLz0rbzVT3EJja1mF7+0PDVUu/W9NwV/tSFs+9tY2jW9oOO5uvmGl SkYAn5jV4i8X6jz7yD5oFr9YdifBUPl5Z5D5KHafq9jVlQD+ixm6j2IKe/edzR3LtK/z yIsg== X-Gm-Message-State: AOAM532tZOoro+pWrwNdT0Nz9aGG95R0gzUD1kyUzFYnMOXK0zAR4e7z ZMLwwxQuMeH3sReVJfwW4BBtp5ETUY9i9w== X-Google-Smtp-Source: ABdhPJwJk+bggskRQZYTIK19Vj5/gOsc8Xt4U6CwTBeOCMMcwolTZ42DFwnIN3oQ/01lOMVIoFXaHg== X-Received: by 2002:a9f:2d8c:: with SMTP id v12mr9159217uaj.25.1639564126939; Wed, 15 Dec 2021 02:28:46 -0800 (PST) Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com. [209.85.221.181]) by smtp.gmail.com with ESMTPSA id j192sm325337vkc.39.2021.12.15.02.28.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Dec 2021 02:28:46 -0800 (PST) Received: by mail-vk1-f181.google.com with SMTP id q21so14325294vkn.2; Wed, 15 Dec 2021 02:28:45 -0800 (PST) X-Received: by 2002:a05:6122:920:: with SMTP id j32mr2889520vka.20.1639564125403; Wed, 15 Dec 2021 02:28:45 -0800 (PST) MIME-Version: 1.0 References: <20211213163929.7509-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20211213163929.7509-1-andriy.shevchenko@linux.intel.com> From: Geert Uytterhoeven Date: Wed, 15 Dec 2021 11:28:34 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 1/2] pinctrl: Get rid of duplicate of_node assignment in the drivers To: Andy Shevchenko Cc: Linus Walleij , Marc Zyngier , Sam Shih , Zhiyong Tao , Ludovic Desroches , Claudiu Beznea , Radim Pavlik , Kavyasree Kotagiri , Colin Foster , Douglas Anderson , Bjorn Andersson , Dmitry Baryshkov , Herve Codina , "open list:GPIO SUBSYSTEM" , Linux ARM , linux-actions@lists.infradead.org, Linux Kernel Mailing List , bcm-kernel-feedback-list , linux-rpi-kernel , - , ALSA Development Mailing List , linux-mediatek@lists.infradead.org, linux-oxnas@groups.io, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm , Linux-Renesas , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , Charles Keepax , Richard Fitzgerald , Sean Wang , Basavaraj Natikar , Shyam Sundar S K , Nicolas Ferre , Alexandre Belloni , Support Opensource , Baruch Siach , Neil Armstrong , Maxime Coquelin , Alexandre Torgue , Andy Gross , Geert Uytterhoeven , Viresh Kumar , Shiraz Hashim , arm-soc Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Dec 13, 2021 at 5:40 PM Andy Shevchenko wrote: > GPIO library does copy the of_node from the parent device of > the GPIO chip, there is no need to repeat this in the individual > drivers. Remove these assignment all at once. > > For the details one may look into the of_gpio_dev_init() implementation. > > Signed-off-by: Andy Shevchenko > drivers/pinctrl/renesas/pinctrl-rza2.c | 1 - Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds