From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>
Subject: Re: [PATCH] gpio: gpio-reg: fix build
Date: Sun, 24 Dec 2017 16:49:39 +0100 [thread overview]
Message-ID: <CAMuHMdWuHsM2TQaTsK4=XTq-Q1ea7CaNEMhWzDgt_ppqssxYpQ@mail.gmail.com> (raw)
In-Reply-To: <20171206173745.19853-1-grygorii.strashko@ti.com>
Hi Grygorii,
On Wed, Dec 6, 2017 at 6:37 PM, Grygorii Strashko
<grygorii.strashko@ti.com> wrote:
> Revert changes introduced by commit f0fbe7bce733 ("gpio: Move irqdomain
> into struct gpio_irq_chip") as they are not aplicable to this driver.
>
> Cc: Russell King - ARM Linux <linux@armlinux.org.uk>
> Fixes: f0fbe7bce733 ("gpio: Move irqdomain into struct gpio_irq_chip")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> Sorry, for inconvenience, but this driver has no users in lkml and
> it can't be enabled through defconfig - only selected, so builds can't
> be verified in standard way.
Seems like we need:
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -392,7 +392,7 @@ config GPIO_RCAR
Say yes here to support GPIO on Renesas R-Car SoCs.
config GPIO_REG
- bool
+ bool "32-bit single register GPIO fixed in/out support" if COMPILE_TEST
help
A 32-bit single register GPIO fixed in/out implementation. This
can be used to represent any register as a set of GPIO signals.
Any dependencies to be added?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2017-12-24 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 17:37 [PATCH] gpio: gpio-reg: fix build Grygorii Strashko
2017-12-07 8:56 ` Linus Walleij
2017-12-24 15:49 ` Geert Uytterhoeven [this message]
2017-12-24 15:56 ` Russell King - ARM Linux
2017-12-24 17:44 ` Linus Walleij
2017-12-24 17:59 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWuHsM2TQaTsK4=XTq-Q1ea7CaNEMhWzDgt_ppqssxYpQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=grygorii.strashko@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).