Re: [PATCH v8] pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Linus,

On Tue, Mar 5, 2024 at 9:58 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Mar 5, 2024 at 9:00 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Fri, Mar 1, 2024 at 2:30 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > > From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> > >
> > > The Awinic AW9523(B) is a multi-function I2C gpio expander in a
> > > TQFN-24L package, featuring PWM (max 37mA per pin, or total max
> > > power 3.2Watts) for LED driving capability.
> > >
> > > It has two ports with 8 pins per port (for a total of 16 pins),
> > > configurable as either PWM with 1/256 stepping or GPIO input/output,
> > > 1.8V logic input; each GPIO can be configured as input or output
> > > independently from each other.
> > >
> > > This IC also has an internal interrupt controller, which is capable
> > > of generating an interrupt for each GPIO, depending on the
> > > configuration, and will raise an interrupt on the INTN pin to
> > > advertise this to an external interrupt controller.
> > >
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> > > Signed-off-by: David Bauer <mail@david-bauer.net>
> > > Reported-by: kernel test robot <lkp@intel.com>
> >
> > This "Reported-by" should not be here, especially since the issue
> > reported[1] was not fixed, and is now in next[2].
>
> Oops I dropped the tag.
>
> > [1] https://lore.kernel.org/all/202106251415.3UY7htNp-lkp@intel.com/
> > [2] http://kisskb.ellerman.id.au/kisskb/buildresult/15135594/
>
> I wonder what the problem is though since the driver
> depends on OF && I2C...

CONFIG_PINCTRL_AW9523=y (bool)
CONFIG_I2C=m (tristate)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds