From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 4/8] drivers/pinctrl: make sh-pfc/core.c explicitly non-modular Date: Wed, 2 Mar 2016 12:05:39 +0100 Message-ID: References: <1456778924-20730-1-git-send-email-paul.gortmaker@windriver.com> <1456778924-20730-5-git-send-email-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ig0-f194.google.com ([209.85.213.194]:33578 "EHLO mail-ig0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbcCBLFk (ORCPT ); Wed, 2 Mar 2016 06:05:40 -0500 In-Reply-To: <1456778924-20730-5-git-send-email-paul.gortmaker@windriver.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Paul Gortmaker , Linus Walleij Cc: "linux-kernel@vger.kernel.org" , Laurent Pinchart , Geert Uytterhoeven , linux-renesas-soc@vger.kernel.org, "linux-gpio@vger.kernel.org" On Mon, Feb 29, 2016 at 9:48 PM, Paul Gortmaker wrote: > The Kconfig / Makefile currently controlling compilation of this code is: > > drivers/pinctrl/sh-pfc/Makefile:obj-$(CONFIG_PINCTRL_SH_PFC) += sh-pfc.o > drivers/pinctrl/sh-pfc/Makefile:sh-pfc-objs = core.o pinctrl.o > > drivers/pinctrl/sh-pfc/Kconfig:config PINCTRL_SH_PFC > drivers/pinctrl/sh-pfc/Kconfig: def_bool y > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init already wasn't being used in this code, the init > ordering remains unchanged with this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Laurent Pinchart > Cc: Geert Uytterhoeven > Cc: Linus Walleij > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker Acked-by: Geert Uytterhoeven Linus: Feel free to take this with the other patches from the series. Or do you prefer I queue it up in sh-pfc-for-v4.7? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds