From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Yash Shah <yash.shah@sifive.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: gpio: sifive,gpio: Group interrupt tuples
Date: Fri, 26 Nov 2021 08:47:55 +0100 [thread overview]
Message-ID: <CAMuHMdX0awdFCB+vWyy5TZMUeKoii8_Y8NaZO77sMaOniaOy1g@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdaFBOq4-Pok3au+Q8uAXe5QscO81JYAhXwMS9B2FjuUiw@mail.gmail.com>
Hi Linus,
On Fri, Nov 26, 2021 at 2:22 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, Nov 25, 2021 at 4:20 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > To improve human readability and enable automatic validation, the tuples
> > in "interrupts" properties should be grouped using angle brackets.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> (...)
> > - interrupts = <7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22>;
> > + interrupts = <7>, <8>, <9>, <10>, <11>, <12>, <13>, <14>, <15>, <16>,
> > + <17>, <18>, <19>, <20>, <21>, <22>;
>
> Tuples? Hm they look single. Like singletons?
Yeah, plic has #interrupt-cells = <1>.
> Anyway:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-11-26 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 15:20 [PATCH] dt-bindings: gpio: sifive,gpio: Group interrupt tuples Geert Uytterhoeven
2021-11-26 1:22 ` Linus Walleij
2021-11-26 7:47 ` Geert Uytterhoeven [this message]
2021-12-01 8:31 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdX0awdFCB+vWyy5TZMUeKoii8_Y8NaZO77sMaOniaOy1g@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).