[PATCH v3] gpio: aggregator: fix macros coding style error

[PATCH v3] gpio: aggregator: fix macros coding style error

[Li Jun]

These changes just fix Linux Kernel Coding Style, no functional
improve.

-Macros with complex values should be enclosed in parentheses

Signed-off-by: Li Jun <lijun01@kylinos.cn>
---
 drivers/gpio/gpio-aggregator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c
index 6f941db02c04..16c1ddc66013 100644
--- a/drivers/gpio/gpio-aggregator.c
+++ b/drivers/gpio/gpio-aggregator.c
@@ -247,8 +247,8 @@ struct gpiochip_fwd {
 	unsigned long tmp[];		/* values and descs for multiple ops */
 };
 
-#define fwd_tmp_values(fwd)	&(fwd)->tmp[0]
-#define fwd_tmp_descs(fwd)	(void *)&(fwd)->tmp[BITS_TO_LONGS((fwd)->chip.ngpio)]
+#define fwd_tmp_values(fwd)	(&(fwd)->tmp[0])
+#define fwd_tmp_descs(fwd)	((void *)&(fwd)->tmp[BITS_TO_LONGS((fwd)->chip.ngpio)])
 
 #define fwd_tmp_size(ngpios)	(BITS_TO_LONGS((ngpios)) + (ngpios))
 
-- 
2.25.1

Re: [PATCH v3] gpio: aggregator: fix macros coding style error

[Geert Uytterhoeven]

On Thu, 31 Jul 2025 at 11:16, Li Jun <lijun01@kylinos.cn> wrote:
> These changes just fix Linux Kernel Coding Style, no functional
> improve.
>
> -Macros with complex values should be enclosed in parentheses
>
> Signed-off-by: Li Jun <lijun01@kylinos.cn>

Please add tags given on earlier versions.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3] gpio: aggregator: fix macros coding style error

[Bartosz Golaszewski]

On Thu, Jul 31, 2025 at 12:14 PM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
>
> On Thu, 31 Jul 2025 at 11:16, Li Jun <lijun01@kylinos.cn> wrote:
> > These changes just fix Linux Kernel Coding Style, no functional
> > improve.
> >
> > -Macros with complex values should be enclosed in parentheses
> >
> > Signed-off-by: Li Jun <lijun01@kylinos.cn>
>
> Please add tags given on earlier versions.

And also the changelog between versions.

Bart

> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Re: [PATCH v3] gpio: aggregator: fix macros coding style error

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Thu, 31 Jul 2025 17:16:37 +0800, Li Jun wrote:
> These changes just fix Linux Kernel Coding Style, no functional
> improve.
> 
> -Macros with complex values should be enclosed in parentheses
> 
> 

Applied, thanks!

[1/1] gpio: aggregator: fix macros coding style error
      https://git.kernel.org/brgl/linux/c/7ce73ee6dc5977fd9dbe8194e7e8073a2f9a50fb

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>