From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH/RFC v2] gpio: rcar: Add Runtime PM handling for interrupts Date: Thu, 25 Feb 2016 15:26:15 +0100 Message-ID: References: <1455811590-15836-1-git-send-email-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-io0-f180.google.com ([209.85.223.180]:36120 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760837AbcBYO0Q (ORCPT ); Thu, 25 Feb 2016 09:26:16 -0500 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: Geert Uytterhoeven , Alexandre Courbot , Jon Hunter , Wolfram Sang , Grygorii Strashko , "linux-gpio@vger.kernel.org" , "linux-pm@vger.kernel.org" , linux-renesas-soc@vger.kernel.org Hi Linus, On Thu, Feb 25, 2016 at 3:19 PM, Linus Walleij wrote: > On Thu, Feb 25, 2016 at 10:37 AM, Geert Uytterhoeven > wrote: >> On Thu, Feb 25, 2016 at 10:07 AM, Linus Walleij >> wrote: >>> On Thu, Feb 18, 2016 at 5:06 PM, Geert Uytterhoeven >>> wrote: >>> >>>> The R-Car GPIO driver handles Runtime PM for requested GPIOs only. >>>> >>>> When using a GPIO purely as an interrupt source, no Runtime PM handling >>>> is done, and the GPIO module's clock may not be enabled. >>>> >>>> To fix this: >>>> - Add .irq_request_resources() and .irq_release_resources() callbacks >>>> to handle Runtime PM when an interrupt is requested, >>>> - Add irq_bus_lock() and sync_unlock() callbacks to handle Runtime PM >>>> when e.g. disabling/enabling an interrupt, or configuring the >>>> interrupt type. >>>> >>>> Signed-off-by: Geert Uytterhoeven >>> >>> Patch applied with Marc's ACK. >> >> Thanks! >> >> Can we have it in v4.5? Else Ethernet won't work on r8a7795/salvator-x. > > Argh that is late. But I'll move it over to the fixes branch... Thanks! The issue was exposed by commit d5c3d84657db57bd ("net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS"), which went upstream only in v4.5-rc3. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds