linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Johan Hovold <johan@kernel.org>,
	Alexandre Courbot <acourbot@nvidia.com>,
	Michael Welling <mwelling@ieee.org>,
	Markus Pargmann <mpa@pengutronix.de>,
	Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH 134/182] m68k: gpio: switch to gpiochip_add_data()
Date: Wed, 9 Dec 2015 14:59:36 +0100	[thread overview]
Message-ID: <CAMuHMdXhcaDfhwOR6Cw+zU+AWFPNftiZ0NtQPS9nssH1YfkC8A@mail.gmail.com> (raw)
In-Reply-To: <1449668315-4352-1-git-send-email-linus.walleij@linaro.org>

Hi Linus,

On Wed, Dec 9, 2015 at 2:38 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> We're planning to remove the gpiochip_add() function to swith
> to gpiochip_add_data() with NULL for data argument.

Just wondering, and I don't think this was clarified in the cover letter
(I'm not subscribed to linux-gpio, so I used a web archive): why don't you keep
gpiochip_add() as an inline wrapper around gpiochip_add_data()?
That would avoid conversions like this one.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2015-12-09 13:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 13:38 [PATCH 134/182] m68k: gpio: switch to gpiochip_add_data() Linus Walleij
2015-12-09 13:59 ` Geert Uytterhoeven [this message]
2015-12-11 18:28   ` Linus Walleij
2015-12-14  0:49 ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdXhcaDfhwOR6Cw+zU+AWFPNftiZ0NtQPS9nssH1YfkC8A@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=acourbot@nvidia.com \
    --cc=gerg@uclinux.org \
    --cc=johan@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mpa@pengutronix.de \
    --cc=mwelling@ieee.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).