From: Haojian Zhuang <haojian.zhuang@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Andrew Ruder" <andrew.ruder@elecsyscorp.com>,
"Marek Vašut" <marek.vasut@gmail.com>,
"Eric Miao" <eric.y.miao@gmail.com>,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Alexandre Courbot" <gnurou@gmail.com>
Subject: Re: [PATCH] gpio-pxa: gpio0 and gpio1 support on dt
Date: Tue, 17 Jun 2014 08:18:36 +0800 [thread overview]
Message-ID: <CAN1soZz__VrLj57yLVTgqLnEUnS2wqaAv71kwnbZ5oRCVVoCNw@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdZ3xfOXrMZK-Z7TteOsdnVP8uOY4+DLe7pv_9ydBCRRWQ@mail.gmail.com>
On Thu, Jun 12, 2014 at 4:43 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, Jun 5, 2014 at 9:13 PM, Andrew Ruder
> <andrew.ruder@elecsyscorp.com> wrote:
>
>> pxa_gpio_probe() has some issues supporting the gpio0 and gpio1
>> interrupts under device-tree - it never actually sets up the chain
>> handler to get interrupts on edge detect for GPIO0 and GPIO1.
>>
>> Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
>
> Makes perfect sense. Can I have an ACK from some PXA
> maintainer on this?
>
> The PXA GPIO driver with it's messy irqchip registration looks
> like a good candidate for switching to the gpiolib irqchip helpers
> and rid some code. Just saying.
>
> Yours,
> Linus Walleij
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
Yes, it's worth to rid some irqchip code.
Regards
Haojian
next prev parent reply other threads:[~2014-06-17 0:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 19:13 [PATCH] gpio-pxa: gpio0 and gpio1 support on dt Andrew Ruder
2014-06-12 8:43 ` Linus Walleij
2014-06-17 0:18 ` Haojian Zhuang [this message]
2014-07-07 10:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN1soZz__VrLj57yLVTgqLnEUnS2wqaAv71kwnbZ5oRCVVoCNw@mail.gmail.com \
--to=haojian.zhuang@gmail.com \
--cc=andrew.ruder@elecsyscorp.com \
--cc=eric.y.miao@gmail.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).