From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haojian Zhuang Subject: Re: [PATCH] gpio-pxa: gpio0 and gpio1 support on dt Date: Tue, 17 Jun 2014 08:18:36 +0800 Message-ID: References: <1401995603-25997-1-git-send-email-andrew.ruder@elecsyscorp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-we0-f181.google.com ([74.125.82.181]:64406 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751573AbaFQASi (ORCPT ); Mon, 16 Jun 2014 20:18:38 -0400 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: Andrew Ruder , =?UTF-8?B?TWFyZWsgVmHFoXV0?= , Eric Miao , Russell King - ARM Linux , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Alexandre Courbot On Thu, Jun 12, 2014 at 4:43 PM, Linus Walleij wrote: > On Thu, Jun 5, 2014 at 9:13 PM, Andrew Ruder > wrote: > >> pxa_gpio_probe() has some issues supporting the gpio0 and gpio1 >> interrupts under device-tree - it never actually sets up the chain >> handler to get interrupts on edge detect for GPIO0 and GPIO1. >> >> Signed-off-by: Andrew Ruder > > Makes perfect sense. Can I have an ACK from some PXA > maintainer on this? > > The PXA GPIO driver with it's messy irqchip registration looks > like a good candidate for switching to the gpiolib irqchip helpers > and rid some code. Just saying. > > Yours, > Linus Walleij Acked-by: Haojian Zhuang Yes, it's worth to rid some irqchip code. Regards Haojian