* [PATCH] gpio-pxa: gpio0 and gpio1 support on dt
@ 2014-06-05 19:13 Andrew Ruder
2014-06-12 8:43 ` Linus Walleij
2014-07-07 10:55 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Ruder @ 2014-06-05 19:13 UTC (permalink / raw)
To: linux-gpio; +Cc: linux-kernel, gnurou, linus.walleij, Andrew Ruder
pxa_gpio_probe() has some issues supporting the gpio0 and gpio1
interrupts under device-tree - it never actually sets up the chain
handler to get interrupts on edge detect for GPIO0 and GPIO1.
Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
---
drivers/gpio/gpio-pxa.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 42e6e64..19f1a95 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -649,6 +649,11 @@ static int pxa_gpio_probe(struct platform_device *pdev)
handle_edge_irq);
set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
}
+ } else {
+ if (irq0 > 0)
+ irq_set_chained_handler(irq0, pxa_gpio_demux_handler);
+ if (irq1 > 0)
+ irq_set_chained_handler(irq1, pxa_gpio_demux_handler);
}
irq_set_chained_handler(irq_mux, pxa_gpio_demux_handler);
--
1.9.0.rc3.12.gbc97e2d
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] gpio-pxa: gpio0 and gpio1 support on dt
2014-06-05 19:13 [PATCH] gpio-pxa: gpio0 and gpio1 support on dt Andrew Ruder
@ 2014-06-12 8:43 ` Linus Walleij
2014-06-17 0:18 ` Haojian Zhuang
2014-07-07 10:55 ` Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2014-06-12 8:43 UTC (permalink / raw)
To: Andrew Ruder, Marek Vašut, Eric Miao,
Russell King - ARM Linux, Haojian Zhuang
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Courbot
On Thu, Jun 5, 2014 at 9:13 PM, Andrew Ruder
<andrew.ruder@elecsyscorp.com> wrote:
> pxa_gpio_probe() has some issues supporting the gpio0 and gpio1
> interrupts under device-tree - it never actually sets up the chain
> handler to get interrupts on edge detect for GPIO0 and GPIO1.
>
> Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
Makes perfect sense. Can I have an ACK from some PXA
maintainer on this?
The PXA GPIO driver with it's messy irqchip registration looks
like a good candidate for switching to the gpiolib irqchip helpers
and rid some code. Just saying.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio-pxa: gpio0 and gpio1 support on dt
2014-06-12 8:43 ` Linus Walleij
@ 2014-06-17 0:18 ` Haojian Zhuang
0 siblings, 0 replies; 4+ messages in thread
From: Haojian Zhuang @ 2014-06-17 0:18 UTC (permalink / raw)
To: Linus Walleij
Cc: Andrew Ruder, Marek Vašut, Eric Miao,
Russell King - ARM Linux, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Alexandre Courbot
On Thu, Jun 12, 2014 at 4:43 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, Jun 5, 2014 at 9:13 PM, Andrew Ruder
> <andrew.ruder@elecsyscorp.com> wrote:
>
>> pxa_gpio_probe() has some issues supporting the gpio0 and gpio1
>> interrupts under device-tree - it never actually sets up the chain
>> handler to get interrupts on edge detect for GPIO0 and GPIO1.
>>
>> Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
>
> Makes perfect sense. Can I have an ACK from some PXA
> maintainer on this?
>
> The PXA GPIO driver with it's messy irqchip registration looks
> like a good candidate for switching to the gpiolib irqchip helpers
> and rid some code. Just saying.
>
> Yours,
> Linus Walleij
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
Yes, it's worth to rid some irqchip code.
Regards
Haojian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio-pxa: gpio0 and gpio1 support on dt
2014-06-05 19:13 [PATCH] gpio-pxa: gpio0 and gpio1 support on dt Andrew Ruder
2014-06-12 8:43 ` Linus Walleij
@ 2014-07-07 10:55 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2014-07-07 10:55 UTC (permalink / raw)
To: Andrew Ruder
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Courbot
On Thu, Jun 5, 2014 at 9:13 PM, Andrew Ruder
<andrew.ruder@elecsyscorp.com> wrote:
> pxa_gpio_probe() has some issues supporting the gpio0 and gpio1
> interrupts under device-tree - it never actually sets up the chain
> handler to get interrupts on edge detect for GPIO0 and GPIO1.
>
> Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
Patch applied with Haojian's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-07 10:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-05 19:13 [PATCH] gpio-pxa: gpio0 and gpio1 support on dt Andrew Ruder
2014-06-12 8:43 ` Linus Walleij
2014-06-17 0:18 ` Haojian Zhuang
2014-07-07 10:55 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).