From: Fabio Estevam <festevam@gmail.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Linus Walleij <linus.walleij@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: freescale: remove generic pin config core support
Date: Thu, 2 Mar 2023 08:41:51 -0300 [thread overview]
Message-ID: <CAOMZO5DiH1f0u2cs7zKyFU6bMBLHTRpqMFuPCB=T8ZzyJxDT2g@mail.gmail.com> (raw)
In-Reply-To: <20230302072132.1051590-1-linux@rasmusvillemoes.dk>
On Thu, Mar 2, 2023 at 4:21 AM Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
>
> No instance of "struct imx_pinctrl_soc_info" sets '.generic_pinconf =
> true', so all of this is effectively dead code.
>
> To make it easier to understand the actual code, remove all the unused
> cruft. This effectively reverts a5cadbbb081c ("pinctrl: imx: add
> generic pin config core support").
>
> It was only in use by a single SOC (imx7ulp) for a few releases, and
> the commit message of dbffda08f0e9 ("pinctrl: fsl: imx7ulp: change to
> use imx legacy binding") suggests that it won't be used in the
> future. Certainly no new user has appeared in 20+ releases, and should
> the need arise, this can be dug out of git history again.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Yes, this makes sense:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
next prev parent reply other threads:[~2023-03-02 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 7:21 [PATCH] pinctrl: freescale: remove generic pin config core support Rasmus Villemoes
2023-03-02 11:41 ` Fabio Estevam [this message]
2023-03-07 13:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5DiH1f0u2cs7zKyFU6bMBLHTRpqMFuPCB=T8ZzyJxDT2g@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=aisheng.dong@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).