From: Ming Yu <a0282524688@gmail.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: tmyu0@nuvoton.com, lee@kernel.org, linus.walleij@linaro.org,
brgl@bgdev.pl, mkl@pengutronix.de, mailhol.vincent@wanadoo.fr,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, wim@linux-watchdog.org,
linux@roeck-us.net, jdelvare@suse.com,
alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v8 3/7] i2c: Add Nuvoton NCT6694 I2C support
Date: Wed, 26 Mar 2025 10:46:17 +0800 [thread overview]
Message-ID: <CAOoeyxUwgxsLNN1i8vM6_NdR+ytesuVA1iE_TSO4CPbSa2sAnw@mail.gmail.com> (raw)
In-Reply-To: <jpaqx2z5io2bvtluexnzrkz4zcvea7qqgpa6bdhm4yzby2rjgb@izncuolmv7tl>
Dear Andi,
Thank you for reviewing,
Andi Shyti <andi.shyti@kernel.org> 於 2025年3月20日 週四 上午7:58寫道：
>
...
> > +enum i2c_baudrate {
> > + I2C_BR_25K = 0,
> > + I2C_BR_50K,
> > + I2C_BR_100K,
> > + I2C_BR_200K,
> > + I2C_BR_400K,
> > + I2C_BR_800K,
> > + I2C_BR_1M
> > +};
>
> do we need all these frequencies? I don't see them use anywhere.
>
Originally, I used module parameters to configure these I2C's baud
rate, Do you think this approach iis suitable?
> Besides, can you please use a proper prefix? I2C_BR_* prefix
> doesn't belong to this driver.
>
Okay, I will fix these macros in the next patch.
Best regards,
Ming
next prev parent reply other threads:[~2025-03-26 2:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 8:16 [PATCH v8 0/7] Add Nuvoton NCT6694 MFD drivers Ming Yu
2025-02-25 8:16 ` [PATCH v8 1/7] mfd: Add core driver for Nuvoton NCT6694 Ming Yu
2025-02-28 8:52 ` Marc Kleine-Budde
2025-03-17 2:26 ` Ming Yu
2025-03-07 1:15 ` Lee Jones
2025-03-17 2:57 ` Ming Yu
2025-03-20 14:50 ` Lee Jones
2025-03-26 2:52 ` Ming Yu
2025-04-04 14:21 ` Lee Jones
2025-04-07 2:25 ` Ming Yu
2025-04-10 8:21 ` Lee Jones
2025-04-21 11:00 ` Ming Yu
2025-02-25 8:16 ` [PATCH v8 2/7] gpio: Add Nuvoton NCT6694 GPIO support Ming Yu
2025-02-25 8:16 ` [PATCH v8 3/7] i2c: Add Nuvoton NCT6694 I2C support Ming Yu
2025-03-19 23:58 ` Andi Shyti
2025-03-26 2:46 ` Ming Yu [this message]
2025-02-25 8:16 ` [PATCH v8 4/7] can: Add Nuvoton NCT6694 CANFD support Ming Yu
2025-02-27 2:08 ` Vincent Mailhol
2025-02-27 6:03 ` Ming Yu
2025-02-27 14:17 ` Marc Kleine-Budde
2025-03-17 2:08 ` Ming Yu
2025-02-28 10:44 ` Marc Kleine-Budde
2025-03-17 2:24 ` Ming Yu
2025-03-17 9:13 ` Marc Kleine-Budde
2025-03-26 2:27 ` Ming Yu
2025-03-26 17:41 ` Marc Kleine-Budde
2025-03-27 5:38 ` Ming Yu
2025-03-27 7:06 ` Marc Kleine-Budde
2025-03-28 2:37 ` Ming Yu
2025-03-28 7:22 ` Marc Kleine-Budde
2025-03-28 8:57 ` Ming Yu
2025-03-28 9:11 ` Marc Kleine-Budde
2025-03-17 10:41 ` Marc Kleine-Budde
2025-03-26 2:37 ` Ming Yu
2025-03-26 17:35 ` Marc Kleine-Budde
2025-03-27 5:30 ` Ming Yu
2025-03-26 21:56 ` Christophe JAILLET
2025-03-27 5:41 ` Ming Yu
2025-02-25 8:16 ` [PATCH v8 5/7] watchdog: Add Nuvoton NCT6694 WDT support Ming Yu
2025-02-25 8:16 ` [PATCH v8 6/7] hwmon: Add Nuvoton NCT6694 HWMON support Ming Yu
2025-02-25 8:16 ` [PATCH v8 7/7] rtc: Add Nuvoton NCT6694 RTC support Ming Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOoeyxUwgxsLNN1i8vM6_NdR+ytesuVA1iE_TSO4CPbSa2sAnw@mail.gmail.com \
--to=a0282524688@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brgl@bgdev.pl \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdelvare@suse.com \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tmyu0@nuvoton.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).