From: "Esteban Blanc" <eblanc@baylibre.com>
To: "Andy Shevchenko" <andy.shevchenko@gmail.com>
Cc: <linus.walleij@linaro.org>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <a.zummo@towertech.it>,
<alexandre.belloni@bootlin.com>, <linux-kernel@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, <linux-rtc@vger.kernel.org>,
<jpanis@baylibre.com>, <jneanne@baylibre.com>,
<aseketeli@baylibre.com>, <sterzik@ti.com>, <u-kumar1@ti.com>
Subject: Re: [PATCH v4 2/3] pinctrl: tps6594: Add driver for TPS6594 pinctrl and GPIOs
Date: Wed, 17 May 2023 11:58:57 +0200 [thread overview]
Message-ID: <CSOGQIRNP61G.1Q2A4ZXB43YYQ@burritosblues> (raw)
In-Reply-To: <CAHp75VdNgBv5yVTXzDpY3rrF31p=p99cfXdEs0q7m8VmLLJwbg@mail.gmail.com>
On Tue May 16, 2023 at 6:48 PM CEST, Andy Shevchenko wrote:
> On Tue, May 16, 2023 at 4:05 PM Esteban Blanc <eblanc@baylibre.com> wrote:
> > On Fri May 12, 2023 at 7:07 PM CEST, wrote:
> > > Fri, May 12, 2023 at 04:17:54PM +0200, Esteban Blanc kirjoitti:
...
> > > > -#define TPS6594_REG_GPIOX_CONF(gpio_inst) (0x31 + (gpio_inst))
> > > > +#define TPS6594_REG_GPIO1_CONF 0x31
> > > > +#define TPS6594_REG_GPIOX_CONF(gpio_inst) (TPS6594_REG_GPIO1_CONF + (gpio_inst))
> > >
> > > Why? The original code with parameter 0 will issue the same.
> >
> > I felt that replacing 0x31 with a constant would make the computation
> > in TPS6594_REG_GPIOX_CONFIG more understandable. What do you think?
>
> The question is why that register is so special that you need to have
> it as a constant explicitly?
It is not special, it's just the first one of the serie of config
registers. I felt like just having 0x31 without context was a bit weird
Best regards,
--
Esteban Blanc
BayLibre
next prev parent reply other threads:[~2023-05-17 9:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 14:17 [PATCH v4 0/3] TI TPS6594 PMIC support (RTC, pinctrl, regulators) Esteban Blanc
2023-05-12 14:17 ` [PATCH v4 1/3] rtc: tps6594: Add driver for TPS6594 RTC Esteban Blanc
2023-05-12 17:22 ` andy.shevchenko
2023-05-17 16:47 ` Esteban Blanc
2023-05-17 16:52 ` Andy Shevchenko
2023-05-22 11:49 ` Esteban Blanc
2023-05-12 14:17 ` [PATCH v4 2/3] pinctrl: tps6594: Add driver for TPS6594 pinctrl and GPIOs Esteban Blanc
2023-05-12 17:07 ` andy.shevchenko
2023-05-16 13:05 ` Esteban Blanc
2023-05-16 16:48 ` Andy Shevchenko
2023-05-17 9:58 ` Esteban Blanc [this message]
2023-05-17 13:51 ` Andy Shevchenko
2023-05-17 14:43 ` Esteban Blanc
2023-05-17 15:04 ` Andy Shevchenko
2023-05-22 8:45 ` Esteban Blanc
2023-05-23 9:26 ` Esteban Blanc
2023-05-23 11:03 ` Andy Shevchenko
2023-05-23 11:32 ` Esteban Blanc
2023-05-12 14:17 ` [PATCH v4 3/3] regulator: tps6594-regulator: Add driver for TI TPS6594 regulators Esteban Blanc
2023-05-12 17:34 ` andy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CSOGQIRNP61G.1Q2A4ZXB43YYQ@burritosblues \
--to=eblanc@baylibre.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=andy.shevchenko@gmail.com \
--cc=aseketeli@baylibre.com \
--cc=broonie@kernel.org \
--cc=jneanne@baylibre.com \
--cc=jpanis@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=sterzik@ti.com \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).