From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE31C77B7A for ; Wed, 31 May 2023 07:59:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235101AbjEaH73 (ORCPT ); Wed, 31 May 2023 03:59:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235062AbjEaH6x (ORCPT ); Wed, 31 May 2023 03:58:53 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D1E0137 for ; Wed, 31 May 2023 00:58:36 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4f3b5881734so6313894e87.0 for ; Wed, 31 May 2023 00:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1685519914; x=1688111914; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Tk+81ZXQRVKIVnL3Dx1sO4lzEgof7lw/v2BMgCYOmWM=; b=bOr8Fp2dFZurkI/5395Fr9A4FzFobM3CAAB8Yep+0/xVZ+fxfeze96CKzQ6emmQwjS xMpVKQ8ij0ej7N+d3kN7jl6tZmMdzhysVG4YctDZqwjimaORs+3l0xMD6vuG4xgR74++ Z8BF8LVEYPISAaUMs27RFaN6tAZR4zz+FjngyqsohNpIe/+n5L7jBP5QKCuqdclywSXn SDUTZWzIvofbaWuunhdLSKlnPc5DCifUYwUKCtLFOTMgXgTBJ3eYGKkTcDmc4JEllzr4 X3ccPRmMyd0hru+lrlcHNWljEkjAIul4efx4wGbctKIyBAsGxzJ+VF1hRTuAtVQ2LAPt LeJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685519914; x=1688111914; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Tk+81ZXQRVKIVnL3Dx1sO4lzEgof7lw/v2BMgCYOmWM=; b=XmkxZVph1mwNHhVGRJv04hhb15pnBmjFp7pXTDVcGzx4Trv3fXu9VRPGdr4WJRSOoI 1qTy9DHRcpAFy2VPSOKIGTl3fkxR4q7GdwWb/0APLxdz6tI87nRqCPB0PX1tZHfYv0/g hkdVK1+cOwB8dJyMcgA3o27I/fIaKPezIyC8bBiOhjrOgdWI7aDOg7qDr2DuLojmF/A0 xo0v0vJMZKmaJXNgNggpD5zdtcPqe47mxTlkfdKk/aNWfrS8X2VhoRyg7MttjYLKcITf GilsXHkT/QjyKIA4AxkrYSrFqKDS0iCZ7KXoOyd29G9ZPd8HTofDlv1+lvvX4Eh70re1 I5nQ== X-Gm-Message-State: AC+VfDyqfK/k6Ik8IJrJz57ScsYJBzwdmRKWfD6cHsiCsWUoHRQWpQrZ EVofLlcCbDvq4xwDRJUDIC/s5p0nkR8BynJtk0EPxg== X-Google-Smtp-Source: ACHHUZ6zMVr3+z7bUbOrkL8Kg0K8opWfYNkWLJgaVTR13nUS37NfKhRFO8bBUDjp0qvLhP/3Rp2gOQ== X-Received: by 2002:ac2:511c:0:b0:4f3:9868:bee4 with SMTP id q28-20020ac2511c000000b004f39868bee4mr2006029lfb.32.1685519914087; Wed, 31 May 2023 00:58:34 -0700 (PDT) Received: from localhost ([2a01:e0a:28d:66d0:512f:eb5f:2a12:360b]) by smtp.gmail.com with ESMTPSA id n14-20020a1c720e000000b003f4b6bcbd8bsm19893663wmc.31.2023.05.31.00.58.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 00:58:33 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 31 May 2023 09:58:32 +0200 Message-Id: To: "Andy Shevchenko" Cc: , , , , , , , , , , , Subject: Re: [PATCH v5 2/3] pinctrl: tps6594: Add driver for TPS6594 pinctrl and GPIOs From: "Esteban Blanc" X-Mailer: aerc 0.14.0 References: <20230522163115.2592883-1-eblanc@baylibre.com> <20230522163115.2592883-3-eblanc@baylibre.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri May 26, 2023 at 8:43 PM CEST, Andy Shevchenko wrote: > On Thu, May 25, 2023 at 5:07=E2=80=AFPM Esteban Blanc wrote: > > On Tue May 23, 2023 at 9:14 PM CEST, wrote: > > > Mon, May 22, 2023 at 06:31:14PM +0200, Esteban Blanc kirjoitti: > > ... > > > > > +// Used to compute register address of GPIO1_CONF to GPIO11_CONF > > > > > > This is good. > > Btw > > the register Ah yes, thanks. > and shouldn't it start from GPIO0_CONF (please, double check, my > memory can do tricks on me)? On Linux side it is GPIO0 but on datasheet side it is GPIO1_CONF to GPIO11_CONF. I was referring to the "real" register names (datasheet ones) > > --=20 > With Best Regards, > Andy Shevchenko