Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: "Erik Schilling" <erik.schilling@linaro.org>
To: "Bartosz Golaszewski" <brgl@bgdev.pl>
Cc: <linux-gpio@vger.kernel.org>,
	"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
	"Kent Gibson" <warthog618@gmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Joe Slater" <joe.slater@windriver.com>
Subject: Re: [libgpiod][PATCH] tools: tests: port tests to shunit2
Date: Thu, 22 Jun 2023 16:35:28 +0200	[thread overview]
Message-ID: <CTJ95UFCTP75.AAR2V3ULQOE9@fedora> (raw)
In-Reply-To: <CAMRc=MeF2yv1F=vAqDJkE7rNVBJDN6a_b77YjBkrC2p8xv8PqA@mail.gmail.com>

On Thu Jun 22, 2023 at 4:10 PM CEST, Bartosz Golaszewski wrote:
> On Thu, Jun 22, 2023 at 4:07 PM Erik Schilling
> <erik.schilling@linaro.org> wrote:
> >
> > Just took a look at this since I am looking for ways to invoke the Rust
> > binding tests...
> >
> > On Tue Jun 20, 2023 at 2:41 PM CEST, Bartosz Golaszewski wrote:
> > > +# Check all required non-coreutils tools
> > > +check_prog shunit2
> > > [...]
> > > +. shunit2
> >
> > Hm... How does this work for you? Under Fedora shunit2 seems to be
> > packaged to install into /usr/share/shunit2. The installed examples of
> > the package are sourcing that. So the check_prog check fails since there
> > is no binary in $PATH and the . shunit2 fails since there is no shunit2
> > in $PWD.
> >
> > Am I missing some necessary setup step?
> >
> > - Erik
> >
>
> On ubuntu and debian it's shipped in /usr/bin/shunit2 as it should.
> Upstream docs suggest using it as an executable as one of two
> supported ways (next to sourcing) so it should definitely go into
> /usr/bin/. I think it's just a fedora quirk. Maybe suggest a change?

Done: https://bugzilla.redhat.com/show_bug.cgi?id=2216783

- Erik

      reply	other threads:[~2023-06-22 14:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 12:41 [libgpiod][PATCH] tools: tests: port tests to shunit2 Bartosz Golaszewski
2023-06-20 13:43 ` Kent Gibson
2023-06-20 15:19   ` Bartosz Golaszewski
2023-06-20 15:36     ` Kent Gibson
2023-06-20 17:28       ` Bartosz Golaszewski
2023-06-22 14:07 ` Erik Schilling
2023-06-22 14:10   ` Bartosz Golaszewski
2023-06-22 14:35     ` Erik Schilling [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CTJ95UFCTP75.AAR2V3ULQOE9@fedora \
    --to=erik.schilling@linaro.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=joe.slater@windriver.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=viresh.kumar@linaro.org \
    --cc=warthog618@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox