public inbox for linux-gpio@vger.kernel.org
 help / color / mirror / Atom feed
From: "Erik Schilling" <erik.schilling@linaro.org>
To: "Bartosz Golaszewski" <brgl@bgdev.pl>
Cc: "Linux-GPIO" <linux-gpio@vger.kernel.org>,
	"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH libgpiod] gpiosim: fix data race that corrupts heap
Date: Mon, 26 Jun 2023 18:41:30 +0200	[thread overview]
Message-ID: <CTMQCJ195FCW.3NQSZGRPNM6EZ@fedora> (raw)
In-Reply-To: <CAMRc=Mcn9N2+nQKCW6_Yu_urHuTtEcGzdeJyRbTa9YYTFKx_gQ@mail.gmail.com>

On Mon Jun 26, 2023 at 4:36 PM CEST, Bartosz Golaszewski wrote:
> Nice catch, thanks!
> I applied it and just changed the Fixes tag to
> conform to the kernel style.

Thanks! I updated my gitconfig with the correct pretty format.

> I actually saw some issues when running rust tests some time ago but
> couldn't reproduce reliably, I suspect this was it.

Yeah, it was a bit nasty since this mixed up the double-free backtraces
really bad. I was starting at the ref counters and Rust abstractions
for quite a while and could not make sense of it. And once one added
too many debug prints the chance of reproducing it got reduced pretty
severly on my machine.

- Erik


      reply	other threads:[~2023-06-26 16:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-26 13:14 [PATCH libgpiod] gpiosim: fix data race that corrupts heap Erik Schilling
2023-06-26 14:36 ` Bartosz Golaszewski
2023-06-26 16:41   ` Erik Schilling [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CTMQCJ195FCW.3NQSZGRPNM6EZ@fedora \
    --to=erik.schilling@linaro.org \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox