From: "Erik Schilling" <erik.schilling@linaro.org>
To: "Bartosz Golaszewski" <brgl@bgdev.pl>
Cc: "Linux-GPIO" <linux-gpio@vger.kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>
Subject: Re: [libgpiod][PATCH 3/3] bindings: rust: bump major for libgpiod crate
Date: Fri, 29 Sep 2023 14:45:46 +0200 [thread overview]
Message-ID: <CVVETSK5NDXF.139VWJ2R9BIB4@ablu-work> (raw)
In-Reply-To: <CAMRc=MfZKuMfQx2bgfv2dT3VTj8TjMqYNw_d51kTaZXQh7LRKQ@mail.gmail.com>
On Fri Sep 29, 2023 at 2:43 PM CEST, Bartosz Golaszewski wrote:
> On Wed, Sep 27, 2023 at 6:30 PM Erik Schilling
> <erik.schilling@linaro.org> wrote:
> >
> > Since the type changes around ownership of line_info instances are not
> > necessarily transparent to the user, we bump the major for the next
> > release of the crate.
> >
> > Note:
> > I am using the term "major" as defined in the Rust SemVer compatibility
> > guide [1], where the first non-zero digit is considered as "major".
> >
> > [1] https://doc.rust-lang.org/cargo/reference/semver.html
> >
> > Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
> > ---
> > bindings/rust/libgpiod/Cargo.toml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/bindings/rust/libgpiod/Cargo.toml b/bindings/rust/libgpiod/Cargo.toml
> > index 518e5e5..3be4aa0 100644
> > --- a/bindings/rust/libgpiod/Cargo.toml
> > +++ b/bindings/rust/libgpiod/Cargo.toml
> > @@ -4,7 +4,7 @@
> >
> > [package]
> > name = "libgpiod"
> > -version = "0.1.0"
> > +version = "0.2.0"
> > authors = ["Viresh Kumar <viresh.kumar@linaro.org>"]
> > description = "libgpiod wrappers"
> > repository = "https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git"
> >
> > --
> > 2.41.0
> >
>
> Isn't it something that we should do right before tagging the release
> once we know the final requirement for the version change? At least
> this is what I do for the rest of libgpiod.
Yep. Probably thats better. Then we can also use that as a signal of
intended publish to crates.io.
Will drop from this series and send again once all current Rust patches
landed.
- Erik
prev parent reply other threads:[~2023-09-29 12:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 16:29 [libgpiod][PATCH 0/3] bindings: rust: fix modeling of line_info lifetimes Erik Schilling
2023-09-27 16:29 ` [libgpiod][PATCH 1/3] bindings: rust: fix soundness of line_info modeling Erik Schilling
2023-09-28 11:27 ` Viresh Kumar
2023-09-28 12:27 ` Erik Schilling
2023-09-29 10:39 ` Viresh Kumar
2023-09-29 10:58 ` Erik Schilling
2023-09-29 11:02 ` Viresh Kumar
2023-09-28 13:24 ` Erik Schilling
2023-09-29 10:39 ` Viresh Kumar
2023-09-29 11:06 ` Erik Schilling
2023-09-29 10:50 ` Manos Pitsidianakis
2023-09-27 16:29 ` [libgpiod][PATCH 2/3] bindings: rust: allow cloning line::Info -> line::OwnedInfo Erik Schilling
2023-09-28 12:52 ` Erik Schilling
2023-09-29 10:50 ` Viresh Kumar
2023-09-29 11:05 ` Erik Schilling
2023-09-27 16:29 ` [libgpiod][PATCH 3/3] bindings: rust: bump major for libgpiod crate Erik Schilling
2023-09-29 12:43 ` Bartosz Golaszewski
2023-09-29 12:45 ` Erik Schilling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CVVETSK5NDXF.139VWJ2R9BIB4@ablu-work \
--to=erik.schilling@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
--cc=manos.pitsidianakis@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox