From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61E5E81742; Wed, 21 Feb 2024 16:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708531521; cv=none; b=E3IZV/llhIAWrPUm7EfcOBK1yxzQJfarfSR1wm9usgOkiL0WsauLbN7pjST/6i65dXe4BF5zl4/900YZWhsIEc2b1+LWhrW+TZcsRXrQsCqdzHi6ZqcPMB+elPZ3xySbw9Vt5c2DsH47zmSQAErYXmjlPH2FkLZOIycBMwpE3Uo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708531521; c=relaxed/simple; bh=4osHeqTpGZbNF+WwFOeN/1hOUN/aK+g+cz/1SRJB+9E=; h=Mime-Version:Content-Type:Date:Message-Id:From:Subject:Cc:To: References:In-Reply-To; b=NdmFB497uoovKSCJN8K+jeSGbkBmpRtHwOjhz/+fcE5d34v32RZCL0O1wLfOjGIFrSDqNjEVLWZ4bJDs8xM2gOKeX1nVl7Kv4u9LG98PJqBV2Fr1yjMUBQ49gHTKDYmFRDBC/DmL6Yvmt7/K+FhpsO5mOYakmugOT9SEYp2izlg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=jB2y2QNw; arc=none smtp.client-ip=217.70.183.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="jB2y2QNw" Received: by mail.gandi.net (Postfix) with ESMTPSA id DAA2EC0013; Wed, 21 Feb 2024 16:05:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708531516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KMfvDi1Z7NgcdHnP3iiFwTVbi7e7yWaAr0kgZz77890=; b=jB2y2QNwjiyNS83wMYPNJMm+XgYPGyoUtT68qdAcfISdumDjJnAr5ntNT7dGwok2HL4NFj 12GzGwCkAwWNFq+EbRQvj5zbXIGTQq7s2RzdCCfyaAOuibep9mEJpmFn5v5vlNzpf3Z8rX eWIh/K0nbUoWeTtZEm78NCgOVVzVPizrG2HQfW6I6HkiEpRLVrhScpd4/Ekg24F9nMTrGF vbsV+08topQMABL2LlP90n4ytitLV4/ihLVQx2w7plXfvhUON02JXjxPmNpf+tZb+TYUPk ZBs/cLF51a/rLam1ul/DfP0K+LmrRBXD7lUdgN8+UchNJJmbyAadX9gR4LDYbA== Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 21 Feb 2024 17:05:15 +0100 Message-Id: From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH 13/23] gpio: nomadik: fix offset bug in nmk_pmx_set() Cc: "Bartosz Golaszewski" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Philipp Zabel" , "Thomas Bogendoerfer" , , , , , , "Gregory CLEMENT" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Linus Walleij" X-Mailer: aerc 0.15.2 References: <20240214-mbly-gpio-v1-0-f88c0ccf372b@bootlin.com> <20240214-mbly-gpio-v1-13-f88c0ccf372b@bootlin.com> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com Hello, On Mon Feb 19, 2024 at 10:56 PM CET, Linus Walleij wrote: > On Wed, Feb 14, 2024 at 5:24=E2=80=AFPM Th=C3=A9o Lebrun wrote: > > > Previously, the statement looked like: > > > > slpm[x] &=3D ~BIT(g->pins[i]); > > > > Where: > > - slpm is a unsigned int pointer; > > - g->pins[i] is a pin number which can grow to more than 32. > > > > The expected shift amount is a pin bank offset. > > > > This bug does not occur on every group or pin: the altsetting must be > > NMK_GPIO_ALT_C and the pin must be 32 or above. It is possible that it > > occurred. For example, in pinctrl-nomadik-db8500.c, pin group i2c3_c_2 > > has the right altsetting and has pins 229 and 230. > > > > Signed-off-by: Th=C3=A9o Lebrun > > Ah good catch! > Reviewed-by: Linus Walleij > > I this something I could just apply as a fix or are there > dependencies on other patches? There are dependencies. As Bartosz and you asked, I'll try my best to avoid them and move this patch up in the series, with an appropriate Fixes: trailer (to the initial driver commit I believe). Thanks, -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com