Re: [PATCH v6 07/12] gpio: regmap: Allow to allocate regmap-irq device

Andy Shevchenko
2025-04-14T10:29:47Z

On Thu, Apr 10, 2025 at 11:03:46AM +0200, Mathieu Dubois-Briand wrote:
> On Wed Apr 9, 2025 at 6:39 PM CEST, Andy Shevchenko wrote:
> > On Wed, Apr 09, 2025 at 04:55:54PM +0200, Mathieu Dubois-Briand wrote:

...

> >> +#ifdef CONFIG_REGMAP_IRQ
> >> + if (config->regmap_irq_chip) {
> >> + struct regmap_irq_chip_data *irq_chip_data;
> >> +
> >> + ret = devm_regmap_add_irq_chip_fwnode(config->parent, dev_fwnode(config->parent),
> >> + config->regmap, config->regmap_irq_irqno,
> >> + config->regmap_irq_flags, 0,
> >> + config->regmap_irq_chip, &irq_chip_data);
> >> + if (ret)
> >> + goto err_free_gpio;
> >> +
> >> + irq_domain = regmap_irq_get_domain(irq_chip_data);
> >> + } else
> >> +#endif
> >> + irq_domain = config->irq_domain;
> >
> >> +
> >
> > This is blank line is not needed, but I not mind either way.
>
> I can remove it, but as the line above is potentially part of the
> "else", I have a small preference for keeping it.

Yes, but it's still coupled with the flow. But okay to leave as is.

> >> + if (irq_domain) {
> >> + ret = gpiochip_irqchip_add_domain(chip, irq_domain);
> >> if (ret)
> >> goto err_remove_gpiochip;
> >> }

--
With Best Regards,
Andy Shevchenko