Re: [PATCH v6 04/12] pwm: max7360: Add MAX7360 PWM support

Mathieu Dubois-Briand
2025-04-10T08:48:41Z

On Wed Apr 9, 2025 at 7:00 PM CEST, Andy Shevchenko wrote:
> On Wed, Apr 09, 2025 at 04:55:51PM +0200, mathieu.dubois-briand@bootlin.com wrote:
>> From: Kamel Bouhara <kamel.bouhara@bootlin.com>
>>
>> Add driver for Maxim Integrated MAX7360 PWM controller, supporting up to
>> 8 independent PWM outputs.
>
> ...
>
>> +static void max7360_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
>> +{
>> + struct regmap *regmap;
>> + struct device *dev;
>> +
>> + regmap = pwmchip_get_drvdata(chip);
>> + dev = regmap_get_device(regmap);
>> +}
>
> This will produce compiler warnings. Why do you have this at all?

Some leftover of a previous version, having this clearly does not make
any sense. I'm surprised I didn't get any compiler warning about this.

>
> ...
>
>> + device_set_of_node_from_dev(dev, dev->parent);
>
> This needs broader discussion.

Yes, we can continue our discussion in the pinctrl thread.

Ok with all other comments. Thanks for your review.

--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering