Re: [PATCH v6 01/12] dt-bindings: mfd: gpio: Add MAX7360

Mathieu Dubois-Briand
2025-04-15T11:24:04Z

On Fri Apr 11, 2025 at 6:05 PM CEST, Rob Herring (Arm) wrote:
>
> On Wed, 09 Apr 2025 16:55:48 +0200, Mathieu Dubois-Briand wrote:
>> Add device tree bindings for Maxim Integrated MAX7360 device with
>> support for keypad, rotary, gpios and pwm functionalities.
>>
>> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
>> ---
>> .../bindings/gpio/maxim,max7360-gpio.yaml | 83 ++++++++++
>> .../devicetree/bindings/mfd/maxim,max7360.yaml | 171 +++++++++++++++++++++
>> 2 files changed, 254 insertions(+)
>>
>
> With the typos fixed,
>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Thanks for the tag!

As a quick note, I believe the bindings will be slightly modified in
next version, to address requests on the rotary encoder driver:

--- c/Documentation/devicetree/bindings/mfd/maxim,max7360.yaml
+++ w/Documentation/devicetree/bindings/mfd/maxim,max7360.yaml
@@ -54,6 +54,17 @@ properties:
linux,axis:
$ref: /schemas/input/rotary-encoder.yaml#/properties/linux,axis

+ rotary-encoder,relative-axis:
+ $ref: /schemas/input/rotary-encoder.yaml#/properties/rotary-encoder,relative-axis
+ description:
+ Register a relative axis rather than an absolute one.
+
+ rotary-encoder,steps:
+ $ref: /schemas/input/rotary-encoder.yaml#/properties/rotary-encoder,steps
+
+ rotary-encoder,rollover:
+ $ref: /schemas/input/rotary-encoder.yaml#/properties/rotary-encoder,rollover
+
"#pwm-cells":
const: 3

Best regards,
Mathieu

--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering