From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C171B28468C for ; Wed, 28 May 2025 12:20:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748434822; cv=none; b=ojTSpi8xAafZHLl6U9v7dLCF3A6i2p9BW53xqhrSJzF3cMWtOVWeGRXMZuH6phxdXVqQ7iRHO2lW2/Z+IEZ3QBEOeg085980xyIVQBkzpPM6f6OGK0QWHpTtl5AhWyk3CenHLBTtDk6ckuHmepA6Qo2eC1PXlZ80GfwgGApY6oA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748434822; c=relaxed/simple; bh=LgluqXTAQPOxJPKju8Bo8ViAFRC7s0F2a9tFXlqvtIo=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=LAWy3gC4ZUWygBRQArOzXnLLllWGudjUJvp+amTkRXa+iOyLSF/q/I58FTe7RdTiz9ir/6DxECgxNWkbfdykwiu/XFXNH4ymMw8wT3OA7tnjsYCr5royoGBfRmFb4EdyIeabfBUSdA14oWitTMMo6Bcf2dy/K88Socf8JdMJF0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Up9MwRuH; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Up9MwRuH" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-442d146a1aaso50958545e9.1 for ; Wed, 28 May 2025 05:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748434818; x=1749039618; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nUiSIyBK9bnL6y5jkIEyCSHfBFQ4eE1Z0A1Z3a6M0aM=; b=Up9MwRuHNjPw1rlRQzUew66x7qEPzJiY9UVqJhwvtqIf0Eyo8lBQCHqtWdrA5m9oYE cQuPLlhoGUjI1pgVqE+wE/s544dc0VOLMRzLVEmaDPWy9BpuDGjDTlWu7NHnXkeqYYDi LS/N2aq0Q5HHtM26h+IwOruFH3o0lEwdzLbpOu8LTAoMEIQUmLpzyomxAMNSLuLFe+l+ hN1kFmpyq4xM5UYNtEbrl0NZjqmb8dCbT0mXGc0ahpMwuiHfCCMu3MdqvNnqbNRXfM5M tx3XGeVV7oXENS2jWvJto04TScoaNtoDRPUeSBNGT2V7MU+bmGc+wOKiTULLKBme1g96 wzOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748434818; x=1749039618; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nUiSIyBK9bnL6y5jkIEyCSHfBFQ4eE1Z0A1Z3a6M0aM=; b=SEZC/EcP5vknWPGyRYxf7g9F7wISi7l78Hi8Kn5ZWl+V4drwCXKEAQSAmeG9p+PPx4 WWiHSd+H0wcM1q+gcbCXlT1OaZecvO1jGzxk1Z4w8g5qqAP8SmXqSyb+bjM/sSpH9lvZ wU0ijB8+ANIUHw+IJXXC6w5SysX8cSXfz/iSE72BjZe8oEvhaXqSW8PRoLkQ0jp8uY91 6uf/KfcI9L3DbqIhX+hjyhW284n6CAb0PR8yqV6tcUJJ/iBpbkez30yujZq8zEUQ2+wb X/j9TEUfTGkoTTe3G+C3srwMPz2Hp1DUokp7gX9nZLFE1g4zKVPKVoLXVBjtli37Aeuc 0Vmw== X-Forwarded-Encrypted: i=1; AJvYcCU3B9H5Ks299f+Y6KvDgvjtVzKFwkCqAJLXBAT5vrrDjV4rhhqHF+vehHM5JFYzmvkL9SeJeRGekjiH@vger.kernel.org X-Gm-Message-State: AOJu0YyQYOzdk3MvjIOKTlhFOU6Q+j9BkGSy/MSMmFES/oNbUDUvfSKu 6LOQrjtzOwRA6hWkCvGz0xfkgfLHodQToALxNfTFXqkZy2Xc274xaof7PFsCM1oDTuA= X-Gm-Gg: ASbGncsDOR2LJdtv95at/VpCrOI5zb22deJws4ZxehWulsw28y+JeIioz9Eo0SaAUP3 wqJOJ0WoN/upDbgbgtZV7tWsB8TOCIlCsZCpOq4Hfh0xL9jI9dDMWNJeA3FnmqRFEnnR2rv7+C7 YaibFI0dQgxPm9GT+y+i7V2LxVidE+jedLlBOYdQoPkTmR+I0znV0TYck+C673ZNFK5FjEKSN6j ccU6YpKPAHo7sC3jri9ndMBRegLx3SAYtdbTwUfqI1h38Rbx+AQqpP4Qx3tpJKdzAEwcW3t3/vL Qz7jCk/o/L/6Icf5Y7UEVA4ViUd0ED/HFIFVEw2M9NgVe16zXDzSwyjnEN0R27CCEok= X-Google-Smtp-Source: AGHT+IGZexNRqILydRhcO4IU4n98EZEdu0fFVjtfd4sxx1IIeEAtAXBTC1Us7iU6PxbqQgpjB0cAjw== X-Received: by 2002:a05:600c:3109:b0:43d:1b74:e89a with SMTP id 5b1f17b1804b1-44c941884eamr149032045e9.9.1748434817966; Wed, 28 May 2025 05:20:17 -0700 (PDT) Received: from localhost ([2a00:2381:fd67:101:6c39:59e6:b76d:825]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4507255b619sm15992525e9.22.2025.05.28.05.20.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 May 2025 05:20:17 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 28 May 2025 13:20:16 +0100 Message-Id: Cc: "Bjorn Andersson" , "Linus Walleij" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Srinivas Kandagatla" , "Liam Girdwood" , "Mark Brown" , "Konrad Dybcio" , , , , , , , Subject: Re: [PATCH v4 7/8] arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec From: "Alexey Klimov" To: "Prasad Kumpatla" , "Mohammad Rafi Shaik" X-Mailer: aerc 0.20.0 References: <20250527111227.2318021-1-quic_pkumpatl@quicinc.com> <20250527111227.2318021-8-quic_pkumpatl@quicinc.com> In-Reply-To: <20250527111227.2318021-8-quic_pkumpatl@quicinc.com> On Tue May 27, 2025 at 12:12 PM BST, Prasad Kumpatla wrote: > From: Mohammad Rafi Shaik > > Add nodes for WSA8830 speakers and WCD9370 headset codec > on qcm6490-idp board. > > Enable lpass macros along with audio support pin controls. > > Signed-off-by: Mohammad Rafi Shaik > Co-developed-by: Prasad Kumpatla > Signed-off-by: Prasad Kumpatla > --- > arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 96 +++++++++++++++++++ > .../boot/dts/qcom/qcs6490-audioreach.dtsi | 24 +++++ > 2 files changed, 120 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/d= ts/qcom/qcm6490-idp.dts > index 7a155ef6492e..884abbda74fd 100644 > --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > @@ -18,6 +18,7 @@ > #include "pm7325.dtsi" [..] > +&swr0 { > + status =3D "okay"; > + > + wcd937x_rx: codec@0,4 { > + compatible =3D "sdw20217010a00"; > + reg =3D <0 4>; > + qcom,rx-port-mapping =3D <1 2 3 4 5>; > + qcom,rx-channel-mapping =3D /bits/ 8 <1 2 1 1 2 1 1 2>; > + }; > +}; > + > +&swr1 { > + status =3D "okay"; > + > + wcd937x_tx: codec@0,3 { > + compatible =3D "sdw20217010a00"; > + reg =3D <0 3>; > + qcom,tx-port-mapping =3D <1 1 2 3>; > + qcom,tx-channel-mapping =3D /bits/ 8 <1 2 1 1 2 3 3 4 1 2 3 4>; It will be tremendously useful to add comments that elaborate the {rx,tx}-c= hannel-mapping (and port mapping for what it's worth) here like it is done in other dt fil= es. For example in the same way as it is done in sm8650-qrd.dts or like here: https://lore.kernel.org/linux-arm-msm/20250526-sm8750-audio-part-2-v3-3-744= 29c686bb1@linaro.org/ Best regards, Alexey