From: "Erik Schilling" <erik@riscstar.com>
To: "Bartosz Golaszewski" <brgl@bgdev.pl>
Cc: "Viresh Kumar" <viresh.kumar@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
<linux-gpio@vger.kernel.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH libgpiod 08/10] bindings: rust: update intmap dependency
Date: Wed, 13 Aug 2025 10:24:33 +0200 [thread overview]
Message-ID: <DC15MF6Z3ARY.LIP79ED7CRB3@riscstar.com> (raw)
In-Reply-To: <CAMRc=Me2GchOakK3Hb9g4MBESqZ_tnO87ycnZ8QUc-rbJib=6w@mail.gmail.com>
On Wed Aug 13, 2025 at 9:18 AM CEST, Bartosz Golaszewski wrote:
> On Wed, Aug 13, 2025 at 8:57 AM Erik Schilling <erik@riscstar.com> wrote:
>>
>> On Tue Aug 12, 2025 at 2:10 PM CEST, Bartosz Golaszewski wrote:
>> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>> >
>> > Bump the intmap dependency for libgpiod to the most recent version. The
>> > IntMap type now takes two explicit type arguments for the key and value
>> > so adjust the code accordingly.
>> >
>> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>> > ---
>> > bindings/rust/libgpiod/Cargo.toml | 2 +-
>> > bindings/rust/libgpiod/src/lib.rs | 4 ++--
>> > bindings/rust/libgpiod/src/line_config.rs | 2 +-
>> > bindings/rust/libgpiod/src/line_request.rs | 4 ++--
>> > 4 files changed, 6 insertions(+), 6 deletions(-)
>> >
>> > diff --git a/bindings/rust/libgpiod/Cargo.toml b/bindings/rust/libgpiod/Cargo.toml
>> > index 8b719b7647910269ca2c91fee685da7fcc67feb7..d7fbe7b3669750880b815832a2e5d7c975ed4d7e 100644
>> > --- a/bindings/rust/libgpiod/Cargo.toml
>> > +++ b/bindings/rust/libgpiod/Cargo.toml
>> > @@ -24,7 +24,7 @@ vnext = ["v2_1"]
>> >
>> > [dependencies]
>> > errno = "0.3.13"
>> > -intmap = "2.0.0"
>> > +intmap = "3.1.2"
>> > libc = "0.2.39"
>> > libgpiod-sys = { version = "0.1", path = "../libgpiod-sys" }
>> > thiserror = "2.0"
>>
>> This lib we also expose types through our public contract. But the
>> explcit 3.1.2 floor does not seem to bring any transient bumps of
>> rust-version or other libs. So it seems reasonably low-risk.
>>
>
> So just: intmap = "3" make sense?
Yes!
- Erik
next prev parent reply other threads:[~2025-08-13 8:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 12:10 [PATCH libgpiod 00/10] bindings: rust: prepare v1.0.0 release Bartosz Golaszewski
2025-08-12 12:10 ` [PATCH libgpiod 01/10] bindings: rust: make Buffer::read_edge_events() lifetimes more explicit Bartosz Golaszewski
2025-08-12 12:10 ` [PATCH libgpiod 02/10] bindings: rust: add missing unsafe block ahead of rust version bump Bartosz Golaszewski
2025-08-12 12:10 ` [PATCH libgpiod 03/10] bindings: rust: update bindgen dependency Bartosz Golaszewski
2025-08-12 12:10 ` [PATCH libgpiod 04/10] bindings: rust: update errno dependency Bartosz Golaszewski
2025-08-13 6:56 ` Erik Schilling
2025-08-13 7:18 ` Bartosz Golaszewski
2025-08-13 8:24 ` Erik Schilling
2025-08-13 8:33 ` Bartosz Golaszewski
2025-08-12 12:10 ` [PATCH libgpiod 05/10] bindings: rust: update cc dependency Bartosz Golaszewski
2025-08-12 12:10 ` [PATCH libgpiod 06/10] bindings: rust: update system-deps dependency Bartosz Golaszewski
2025-08-12 12:10 ` [PATCH libgpiod 07/10] bindings: rust: update thiserror dependency Bartosz Golaszewski
2025-08-12 12:10 ` [PATCH libgpiod 08/10] bindings: rust: update intmap dependency Bartosz Golaszewski
2025-08-13 6:57 ` Erik Schilling
2025-08-13 7:18 ` Bartosz Golaszewski
2025-08-13 8:24 ` Erik Schilling [this message]
2025-08-12 12:10 ` [PATCH libgpiod 09/10] bindings: rust: update rust version Bartosz Golaszewski
2025-08-13 6:57 ` Erik Schilling
2025-08-13 7:12 ` Bartosz Golaszewski
2025-08-13 8:24 ` Erik Schilling
2025-08-12 12:10 ` [PATCH libgpiod 10/10] bindings: rust: update crate versions to v1.0.0 Bartosz Golaszewski
2025-08-13 3:27 ` [PATCH libgpiod 00/10] bindings: rust: prepare v1.0.0 release Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC15MF6Z3ARY.LIP79ED7CRB3@riscstar.com \
--to=erik@riscstar.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).