From: "Erik Schilling" <erik@riscstar.com>
To: "Bartosz Golaszewski" <brgl@bgdev.pl>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>
Cc: <linux-gpio@vger.kernel.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH libgpiod 1/3] bindings: rust: complete the unification of exports in examples
Date: Mon, 29 Sep 2025 08:21:31 +0200 [thread overview]
Message-ID: <DD52FTCTUUEU.3H1VCKA0GZVIH@riscstar.com> (raw)
In-Reply-To: <20250926-rust-release-tweaks-v1-1-beae932eb691@linaro.org>
On Fri Sep 26, 2025 at 4:35 PM CEST, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Commit cd32f27dd550 ("bindings: rust: unify imports in examples") failed
> to consistently unify the code across all examples so finish the
> process.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> .../rust/libgpiod/examples/toggle_line_value.rs | 17 +++++++++------
> .../examples/toggle_multiple_line_values.rs | 17 +++++++++------
> .../rust/libgpiod/examples/watch_line_rising.rs | 23 ++++++++++++--------
> .../rust/libgpiod/examples/watch_line_value.rs | 25 +++++++++++++---------
> .../examples/watch_multiple_line_values.rs | 18 +++++++++-------
> 5 files changed, 59 insertions(+), 41 deletions(-)
nit: Was a bit confused by "complete unifications of exports". Shouldn't
this be "imports" (as used by the previous commit)?
next prev parent reply other threads:[~2025-09-29 6:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 14:35 [PATCH libgpiod 0/3] bindings: rust: pre-release tweaks Bartosz Golaszewski
2025-09-26 14:35 ` [PATCH libgpiod 1/3] bindings: rust: complete the unification of exports in examples Bartosz Golaszewski
2025-09-29 6:21 ` Erik Schilling [this message]
2025-09-29 7:29 ` Bartosz Golaszewski
2025-09-26 14:35 ` [PATCH libgpiod 2/3] bindings: rust: update formatting to --edition 2024 Bartosz Golaszewski
2025-09-26 14:35 ` [PATCH libgpiod 3/3] bindings: rust: add examples to the README.md in the libgpiod crate Bartosz Golaszewski
2025-09-29 6:21 ` [PATCH libgpiod 0/3] bindings: rust: pre-release tweaks Erik Schilling
2025-09-29 7:34 ` Viresh Kumar
2025-09-30 7:54 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DD52FTCTUUEU.3H1VCKA0GZVIH@riscstar.com \
--to=erik@riscstar.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).