From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A89D93321D7 for ; Tue, 21 Oct 2025 12:56:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761051376; cv=none; b=npzEUR5cyHtQx0NXWI0rAtV2lrEt6u5c7BuI7xYlwul1b0NezmvIjp8TWiBS4GRiVf1Jam+I2sIwDkvbvikAxKpCc8zGqsPgmKyz7kqAhHhPjFnKMsVVxmzB6ugSwps3E4eJy9j/+3uVh3lwz/yrSomY9v2c/3yYgXJ7h4p+HY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761051376; c=relaxed/simple; bh=G6BUtnjEM/zfg1qCW1pFmzrsk68q9uL7cRAs98tzYYA=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=M/L9Btpu0HE4HOhrLSiWHQt01Vyy4/4TyjIHEvJOuSIHHniDJGAiCgJBUOSP+/vXi9YzqeBorPwOBS1qFjN3BHzZWpfaPu85XzvBPSl/p7cA6YfrFwBurAu+kbbKqc2h8Gq63ouorrPJvWWivaXmRjM/8wLee6ikgUHq3t9EgSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=APVA8szD; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="APVA8szD" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3ee130237a8so3616173f8f.0 for ; Tue, 21 Oct 2025 05:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761051372; x=1761656172; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=D3+jqWip4cBpergxUpE3r3nDPRXBu9AkUkhJj9MutYo=; b=APVA8szDJAiTkZJNaj6Hq1AuBwpvzZ6SSMFTJ1vHdGh14L5DKXxBvCWI8ApIJGsVdQ JROzQdlXEuQnTZRpYCtwqhSdJIJAt4m2ZyHwkqMUQNQ8CzHZXSbiQc+WUtdBVCA0dXIr ZINJbqJOSId0NLQfEBJw3tOgCOKWv/CJUDg1MOXLbixyfMFezCKtU0BSfHwzCJNvAKJD eR/RgeIuMFvUU6iD7C0UvfabIidwx+uu8zAFd91jx7QTXORa4UF6BTQqukOc0OKC2DjV pbkkAhCrgYOrW/YVZnPurAuQi4PtAMMRfFAUgKtXVyjIPNzsmTegpdcdRE9QThVoJILN 1Mug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761051372; x=1761656172; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=D3+jqWip4cBpergxUpE3r3nDPRXBu9AkUkhJj9MutYo=; b=Ayq5ciVxRXWDSz/cJtSUtrbSHjuHIzy7qhBqSSQdv7nRIJNSidZ/33KUwJsSeodpEx FYYfqmid7XLjd0afWWtr404gWEwEPAdhtddEXaA2H7hRU2T1Y7ev3mYBod2hLYxjBvOk 5iIEB0c+c2Z1TfkfxCExHUpdO3IUWVkskp6S+m9AWtSi+VUYBrHgvZgXHKSaXjlQedFH 8RBDAnoAKtm3EpdhWp07e1YlPQ3rLhVeBgDb09hTv7MEfJ3wigvcZIDxd1L6ZdxLBcXc LMvfOiQj2Vk5E6RHruUd0DQDLtDWgVbCGRx4kf4J0HhUmBOD7ZtLihpkOrVvjab1vFWZ 437A== X-Forwarded-Encrypted: i=1; AJvYcCX+dyY5Lu6pmtg8qKmk9vZzNSzSatDZBxs9fC5H8TjVL+sozfR3izJ8bxNW/vNwRc8f1HZlhZTJLpof@vger.kernel.org X-Gm-Message-State: AOJu0YxZMMSO4fRZggJlAuaZTEdVVTMhYt3/v9mxu0hiWF/jM7jOI9N3 JM03+hZKP7FHyn8lcNsnIXB67UCaYsJeZHBd8LPwCdEpcNrLv0rmx7YKjiTVVwT9fqU= X-Gm-Gg: ASbGnctafyZCiK8F8xahxfeVec76U/7kHqnHsQkxog8XaHCXaWeu+KjsXAqjuunuJEZ NxAsfETopf9UgGVToASN+CVc2l4niqtavO6nbRZBtPQGc8ieWmts7lvrqvo1MGG4wE9Jn0g1Qfe HuWvOXvie6Xi2H1q11mxIoeLC30UDPQVPir+PXybb8XPksG4DrON/7ciozq3oAE7/iVRdFweeV/ +u4+8JfW/8/EABy2Y0X/ell0JOC2e7vMbjyISk2HCcJyIGCxbyGS6ItWZ9HcrZAXMLQSdkrenAn WxMn4+Hen+y9eTT5o4/uBJjvNGNcLEJ0pAckNsBVB2lzSoRl6dwlrfF0cKG/XolzxCQAFXckzFF 6NX06dw8Y0rpwvDReHp6ZuVnW+jdW6R3SKuco55G1s5amYooRgRh1Xeb4nUyv8A5FA87XIjUs6h M4363r X-Google-Smtp-Source: AGHT+IGwoXv9N8+tNudgKcCBOtAB/G2QWEcSJ7tMnIbD245sZlfvNJ9I1xX/MPofutEogENazBSdSg== X-Received: by 2002:a05:6000:1a85:b0:427:f012:5943 with SMTP id ffacd0b85a97d-427f01259e0mr7681625f8f.17.1761051371929; Tue, 21 Oct 2025 05:56:11 -0700 (PDT) Received: from localhost ([2a02:c7c:7259:a00:8d4e:2f09:764b:8b5a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427f00b9fdfsm20142679f8f.40.2025.10.21.05.56.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Oct 2025 05:56:11 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 21 Oct 2025 13:56:09 +0100 Message-Id: To: "Bjorn Andersson" Cc: "Konrad Dybcio" , "Linus Walleij" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Konrad Dybcio" , "Srinivas Kandagatla" , "Dmitry Baryshkov" , , , , , Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: qcm2290: add LPASS LPI pin controller From: "Alexey Klimov" X-Mailer: aerc 0.20.0 References: <20251007-rb1_hdmi_audio-v2-0-821b6a705e4c@linaro.org> <20251007-rb1_hdmi_audio-v2-3-821b6a705e4c@linaro.org> In-Reply-To: On Fri Oct 17, 2025 at 11:42 PM BST, Bjorn Andersson wrote: > On Fri, Oct 10, 2025 at 01:29:38PM +0100, Alexey Klimov wrote: >> On Tue Oct 7, 2025 at 1:39 PM BST, Konrad Dybcio wrote: >> > On 10/7/25 4:03 AM, Alexey Klimov wrote: >> >> Add the Low Power Audio SubSystem Low Power Island (LPASS LPI) pin >> >> controller device node required for audio subsystem on Qualcomm >> >> QRB2210 RB1. QRB2210 is based on qcm2290 which is based on sm6115. >> >>=20 >> >> While at this, also add description of lpi_i2s2 pins (active state) >> >> required for audio playback via HDMI/I2S. >> >>=20 >> >> Cc: Srinivas Kandagatla >> >> Signed-off-by: Alexey Klimov >> >> --- >> > >> > [...] >> > >> >> + lpi_i2s2_active: lpi-i2s2-active-state { >> >> + data-pins { >> >> + pins =3D "gpio12"; >> >> + function =3D "i2s2_data"; >> >> + bias-disable; >> >> + drive-strength =3D <8>; >> >> + output-high; >> > >> > I.. doubt output-high is what you want? >>=20 >> Why? Or is it because of some in-kernel gpiod? >>=20 > > What does "output-high" mean for a non-gpio function? This is not efficient. It will be more useful to go straight to the point. This description of pins was taken from Qualcomm downstream code and the similar patch was applied (see provided URL in the prev email). The same problem here and no response: https://lore.kernel.org/linux-arm-msm/d8e202fb-f494-4b5e-bfb9-c94c1fd3af4d@= linaro.org/ After looking at https://lore.kernel.org/linux-arm-msm/39ebaf4e-e91f-4568-8de6-9fc1f805a1e4@= oss.qualcomm.com/ I guess the output-high should removed at all (if it is the case) but it will be more efficient to provide that as a feedback rather than vague responses. Back to your question -- does it matter here if it is gpio or non-gpio function? Best regards, Alexey.