From: "Michael Walle" <mwalle@kernel.org>
To: "Dan Carpenter" <dan.carpenter@linaro.org>,
"Ioana Ciornei" <ioana.ciornei@nxp.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Frank Li" <Frank.Li@nxp.com>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH next] gpio: qixis-fpga: Fix a NULL vs IS_ERR() bug in probe()
Date: Fri, 24 Oct 2025 08:53:40 +0200 [thread overview]
Message-ID: <DDQCS29MOR0K.2TOU2N8QR86Z0@kernel.org> (raw)
In-Reply-To: <aPsaaf0h343Ba7c1@stanley.mountain>
On Fri Oct 24, 2025 at 8:19 AM CEST, Dan Carpenter wrote:
> The devm_platform_ioremap_resource() function doesn't return NULL, it
> returns error pointers. Fix the checking to match.
>
> Fixes: e88500247dc3 ("gpio: add QIXIS FPGA GPIO controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Michael Walle <mwalle@kernel.org>
-michael
next prev parent reply other threads:[~2025-10-24 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 6:19 [PATCH next] gpio: qixis-fpga: Fix a NULL vs IS_ERR() bug in probe() Dan Carpenter
2025-10-24 6:53 ` Michael Walle [this message]
2025-10-27 9:19 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDQCS29MOR0K.2TOU2N8QR86Z0@kernel.org \
--to=mwalle@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=brgl@bgdev.pl \
--cc=dan.carpenter@linaro.org \
--cc=ioana.ciornei@nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).