Re: [PATCH v8 9/9] gpio: realtek: Add driver for Realtek DHC RTD1625 SoC

["Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>]

On Mon Jul 27, 2026 at 1:10 PM CEST, Bartosz Golaszewski wrote:
> On Mon, 27 Jul 2026 10:20:35 +0200, Mathieu Dubois-Briand
> <mathieu.dubois-briand@bootlin.com> said:
>> On Sun Jul 26, 2026 at 2:52 PM CEST, Yu-Chun Lin wrote:
>>> From: Tzuyi Chang <tychang@realtek.com>
>>>
>>> Add support for the GPIO controller found on Realtek DHC RTD1625 SoCs.
>>>
>>> Unlike the existing Realtek GPIO driver (drivers/gpio/gpio-rtd.c),
>>> which manages pins via shared bank registers, the RTD1625 introduces
>>> a per-pin register architecture. Each GPIO line now has its own
>>> dedicated 32-bit control register to manage configuration independently,
>>> including direction, output value, input value, interrupt enable, and
>>> debounce. Therefore, this distinct hardware design requires a separate
>>> driver.
>>>
>>> The RTD1625 GPIO controller has a hardware quirk where both 'assert'
>>> and 'de-assert' interrupts are fired simultaneously on any edge toggle.
>>> The driver works around this quirk to correctly handle edge interrupts.
>>>
>>> Interrupt support is optional for this device, matching the dt-bindings.
>>> If the interrupts property is not provided, the driver simply skips IRQ
>>> initialization and operates purely as a basic GPIO controller.
>>>
>>> Reviewed-by: Linus Walleij <linusw@kernel.org>
>>> Signed-off-by: Tzuyi Chang <tychang@realtek.com>
>>> Co-developed-by: Yu-Chun Lin <eleanor.lin@realtek.com>
>>> Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
>>> ---
>>> Changes in v8:
>>> - Add error handlers in td1625_gpio_irq_handle().
>>> - Move the direction-checking logic from the core to our custom
>>> reg_mask_xlate() callback.
>>> - Add Reviewed-by tag from Linus.
>>> ---
>>
>> Thanks for the fixes.
>>
>> Reviewed-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
>>
>
> Hi!
>
> Please leave series-wide tags under the cover letter, otherwise b4 will only
> apply it to the specific patch under which you commented.
>
> Bart

Sorry, this was a patch-specific review, but the way I sent it was a bit
misleading.

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com