From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49C6F43C057; Tue, 16 Jun 2026 10:58:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781607530; cv=none; b=EUlohbwS/TuvnzbTeo5rXsmh/6SvYfMctfgDZhkjTD+YTxswFabB0n3GjJMSjRNFPqv/Mv+OXldxd2e7/MReR1gQ06ZgNNJeup942qOU+lUyoPWY7mmKTyOX2V1KCDqb7V3iRoYtAgkx5dxAgnVk+7+ZQDlUuSdIjLgVodqT8jo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781607530; c=relaxed/simple; bh=eU9kbAcxQ0cGQSDEN/i/x+otpe2l6cWb/YeRoAGChPQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BHQ9GexTLicptEyeaz584yuVdc9TKwFPs1fovAVdRo7Q9i2qXwT4+4At9y5CjzuzBolAUT2auzsTzpDJXIzY5+NOBGMXOzWdOn27drrtLsd3XJdLhlAo6mq/g2fVQijnPQXhh6hK2x6A3Hin9FwI8nyhTBcqYy/laFC3cII+xZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=IFxdnqDc; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="IFxdnqDc" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 2EFF226EDC; Tue, 16 Jun 2026 12:58:45 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id NayisU07itRP; Tue, 16 Jun 2026 12:58:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1781607524; bh=eU9kbAcxQ0cGQSDEN/i/x+otpe2l6cWb/YeRoAGChPQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IFxdnqDcPQC/o5Jbk+xFM4kXAuc4h27sbMNFqwDVoiGsqPD/DZm3cGSDV17BUsyDl Gb85yejsU7Eky+S2jsM4Me5CqMflcBgZvTmFG3BI8HSrnOLsAYwomPp0W4p+L7H9oE QKZnoZ1pfkWoCM5c5bvPurlFSg5/OmXZyybPdMGrtT9EXB9FxxITYjzHlWpvA07Mtt 0HUi8NIysOozhdoZAylDsFzz+piYln8trQ23gEjjsFoWdMfsm5vyh0h9QR4C3fVwDw ru3uCLr7wuS5uIK5Uy/ie3h0916dHIFIZGlbomIu4f2wj4jNsO2gLUczAZ2hz1S0qI cjGH/zBu6XRtA== From: Marco Scardovi To: Andy Shevchenko , Mika Westerberg Cc: Mika Westerberg , Linus Walleij , Bartosz Golaszewski , Mario Limonciello , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpiolib: acpi: Add quirk for ASUS ROG Strix G614 series Date: Tue, 16 Jun 2026 12:58:31 +0200 Message-ID: In-Reply-To: <20260616102451.GC2990@black.igk.intel.com> References: <20260616090824.5967-1-scardracs@disroot.org> <20260616102451.GC2990@black.igk.intel.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" On Tue, Jun 16, 2026 at 12:24:51 +0200, Mika Westerberg wrote: > On Tue, Jun 16, 2026 at 12:58:04PM +0300, Andy Shevchenko wrote: > > Mika, do you see any problems with disabled (deferred?) interrupt for this type > > of event? I think it might break the suspend-resume (on touchpad event). Also > > do you remember if we ever had touchpad event to be ActiveBoth? > > For starters, why this is ACPI event in the first place? The AML is not > supposed to use the touchpad. > > Touchpad should be using just regular GpioInt(). Does it still work after > this patch? If yes then I think this is definitely okay. Hi Mika, Andy, Yes, the touchpad continues to work perfectly after this patch (even the suspend/resume you asked about). The touchpad itself is initialized and driven by the i2c-hid driver using a standard GpioInt() resource defined in the touchpad device's _CRS method. The ACPI event handler (pin 21) registered under the GPIO controller's _AEI is distinct from this. The DMI quirk (.no_edge_events_on_boot = true) only prevents the initial boot-time trigger of this ACPI event handler when the line is asserted low during initialization. It does not prevent the touchpad driver from requesting and receiving its interrupts. Furthermore, unlike using the "gpiolib_acpi.ignore_interrupt=AMDI0030:00@21" workaround (which would completely disable the ACPI handler), this patch still keeps the ACPI event handler registered. If any edge events occur on this pin post-boot (for example, if the BIOS needs to toggle touchpad states or track device status), the handler will still run normally, avoiding any potential breakage of runtime ACPI functionality. Sidenote Personally I'd wait for Mario for further info: after all it's him the maintainer for AMD side and surely knows more than me.