From: "Heiko Stübner" <heiko@sntech.de>
To: Linus Walleij <linusw@kernel.org>,
Ye Zhang <ye.zhang@rock-chips.com>,
Jonas Karlman <jonas@kwiboo.se>
Cc: linux-rockchip@lists.infradead.org,
Jonas Karlman <jonas@kwiboo.se>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: rockchip: Fix RK3506 pinctrl support
Date: Thu, 19 Nov 2026 22:40:28 +0100 [thread overview]
Message-ID: <R9Lr9e5PRAa-_53xglqBFw@sntech.de> (raw)
In-Reply-To: <20261119211739.566874-1-jonas@kwiboo.se>
Am Donnerstag, 19. November 2026, 22:17:39 Mitteleuropäische Normalzeit schrieb Jonas Karlman:
> The pinctrl driver added in commit dbd2317d7b9f ("pinctrl: rockchip:
> Add rk3506 pinctrl support") depends on a rockchip,ioc1 property not
> documented in dt-bindings to work, i.e. it expects the pinctrl node to
> look something like following:
>
> pinctrl {
> rockchip,pmu = <&gpio0_ioc>;
> rockchip,ioc1 = <&gpio1_ioc>;
> rockchip,grf = <&gpio234_ioc>;
>
> gpio0 { };
> gpio1 { };
> gpio2 { };
> };
>
> With the commit 63113d4fce6c ("pinctrl: rockchip: Add RV1106 pinctrl
> support") the driver gained support for using GPIO bank referenced IO
> control register blocks using the rockchip,grf phandle of the bank node.
>
> Change the driver to work with dt-bindings documented nodes and
> properties, i.e. something like:
>
> pinctrl {
> rockchip,grf = <&gpio234_ioc>;
>
> gpio0 {
> rockchip,grf = <&gpio0_ioc>;
> };
> gpio1 {
> rockchip,grf = <&gpio1_ioc>;
> };
> gpio2 { };
> };
>
> Fixes: dbd2317d7b9f ("pinctrl: rockchip: Add rk3506 pinctrl support")
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
thanks for working on this, also as the rk3506 devicetree has so far
_not_ made it mainline at all, this change cannot break any backwards
compatiblity - as there's nothing to break.
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
prev parent reply other threads:[~2026-11-19 21:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 21:17 [PATCH] pinctrl: rockchip: Fix RK3506 pinctrl support Jonas Karlman
2026-11-19 21:27 ` sashiko-bot
2026-11-19 21:40 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=R9Lr9e5PRAa-_53xglqBFw@sntech.de \
--to=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=ye.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox