linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Fabio Estevam <festevam@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, Sandor Yu <sandor.yu@nxp.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Bruno Thomsen <bruno.thomsen@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: gpio: 74x164: Introduce the 'registers-default' property
Date: Thu, 7 Jan 2021 15:33:55 +0100	[thread overview]
Message-ID: <X/cb0xhqTHV3eBdA@lunn.ch> (raw)
In-Reply-To: <CACRpkdYtjXMOv+G3_hXAiS4J51FKC4kcuDCmqr_kivuh61udPw@mail.gmail.com>

> Indeed, but I don't understand why the phy in this example does not
> have a compatible string?

Normally, PHYs can be enumerated on the bus, in the same way USB and
PCI devices can be enumerated. The device itself then tells you what
it is campatible with, in the same way PCI and USB does. Having a
compatible string is then detrimental, because people get it wrong,
device tree says one thing, the device itself says something else,
which do we trust? There are also boards where different series of
have populated with different pin compatible PHYs. Enumeration just
works, having a compatible would be a problem.

But, there are some PHYs which you cannot enumerate, e.g they do not
respond to MDIO while held in reset, or the silicon is buggy and has
an invalid ID. In those cases, a compatible should be listed with the
correct PHY ID.

	Andrew

  reply	other threads:[~2021-01-07 14:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-30 21:49 [PATCH v3 1/2] dt-bindings: gpio: 74x164: Introduce the 'registers-default' property Fabio Estevam
2020-12-30 21:49 ` [PATCH v3 2/2] " Fabio Estevam
2021-01-05 15:40   ` Linus Walleij
2021-01-05 15:34 ` [PATCH v3 1/2] dt-bindings: " Linus Walleij
2021-01-07 12:16   ` Fabio Estevam
2021-01-07 14:17     ` Linus Walleij
2021-01-07 14:33       ` Andrew Lunn [this message]
2021-01-07 14:25     ` Andrew Lunn
2021-01-07 14:38       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X/cb0xhqTHV3eBdA@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=bruno.thomsen@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=festevam@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sandor.yu@nxp.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).