From: andy.shevchenko@gmail.com
To: Jerome Neanne <jneanne@baylibre.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, tony@atomide.com,
lee@kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org,
Jonathan Cormier <jcormier@criticallink.com>
Subject: Re: [PATCH 2/2] mfd: tps65219: Add gpio cell instance
Date: Fri, 24 Feb 2023 14:17:27 +0200 [thread overview]
Message-ID: <Y/iq18rYjLwnkBrp@surfacebook> (raw)
In-Reply-To: <20230224113837.874264-3-jneanne@baylibre.com>
Fri, Feb 24, 2023 at 12:38:37PM +0100, Jerome Neanne kirjoitti:
> tps65219 PMIC GPIOs are exposed in a standard way:
> gpiodetect
> gpiochip0 [tps65219-gpio] (3 lines)
>
> Signed-off-by: Jonathan Cormier <jcormier@criticallink.com>
> Signed-off-by: Jerome Neanne <jneanne@baylibre.com>
Same issues with the commit message as per previous patch.
...
> @@ -267,6 +267,11 @@ static int tps65219_probe(struct i2c_client *client)
> return ret;
> }
>
> + if (ret) {
> + dev_err(tps->dev, "Failed to add gpio: %d\n", ret);
> + return ret;
> + }
Isn't it a dead code?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-02-24 12:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 11:38 [PATCH 0/2] Add support for TI TPS65219 PMIC GPIO interface Jerome Neanne
2023-02-24 11:38 ` [PATCH 1/2] gpio: tps65219: add GPIO support for TPS65219 PMIC Jerome Neanne
2023-02-24 12:16 ` andy.shevchenko
2023-02-24 12:18 ` andy.shevchenko
2023-02-27 19:20 ` Jon Cormier
2023-02-27 19:51 ` Andy Shevchenko
2023-02-28 11:18 ` jerome Neanne
2023-02-24 11:38 ` [PATCH 2/2] mfd: tps65219: Add gpio cell instance Jerome Neanne
2023-02-24 12:17 ` andy.shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/iq18rYjLwnkBrp@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=jcormier@criticallink.com \
--cc=jneanne@baylibre.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox