From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [libgpiod][PATCH] tools: use 'unsigned int' instead of 'uint'
Date: Fri, 10 Feb 2023 07:47:21 +0800 [thread overview]
Message-ID: <Y+WGCdb7tJOKDQ6u@sol> (raw)
In-Reply-To: <20230209185312.635613-1-brgl@bgdev.pl>
On Thu, Feb 09, 2023 at 07:53:12PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> uint is an old compatibility name that GCC still provides but clang
> doesn't. Use unsigned int instead.
>
> Fixes: 8ffb6489286f ("tools: line name focussed rework")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> tools/tools-common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/tools-common.h b/tools/tools-common.h
> index efbeeb8..5d39170 100644
> --- a/tools/tools-common.h
> +++ b/tools/tools-common.h
> @@ -43,7 +43,7 @@ struct resolved_line {
> int chip_num;
>
> /* offset of line on chip */
> - uint offset;
> + unsigned int offset;
>
> /* line value for gpioget/set */
> int value;
> --
> 2.37.2
>
Oops, my bad.
Reviewed-by: Kent Gibson <warthog618@gmail.com>
prev parent reply other threads:[~2023-02-09 23:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 18:53 [libgpiod][PATCH] tools: use 'unsigned int' instead of 'uint' Bartosz Golaszewski
2023-02-09 23:47 ` Kent Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+WGCdb7tJOKDQ6u@sol \
--to=warthog618@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox