Re: [PATCH V7 1/8] libgpiod: Add libgpiod-sys rust crate

[Kent Gibson <warthog618@gmail.com>]

On Tue, Oct 18, 2022 at 04:52:04PM +0530, Viresh Kumar wrote:
> On 17-10-22, 20:59, Kent Gibson wrote:
> > > diff --git a/bindings/rust/libgpiod-sys/Cargo.toml b/bindings/rust/libgpiod-sys/Cargo.toml
> > > new file mode 100644
> > > index 000000000000..77f82719d269
> > > --- /dev/null
> > > +++ b/bindings/rust/libgpiod-sys/Cargo.toml
> > > @@ -0,0 +1,15 @@
> > > +[package]
> > > +name = "libgpiod-sys"
> > > +version = "0.1.0"
> > > +edition = "2018"
> > > +
> > 
> > Add license and other relevant keys as per the link you helpfully include...
> 
> Is this enough ?
> 

You should add "categories" and "documentation" if you intend to publish
to crates.io.

> diff --git a/bindings/rust/libgpiod-sys/Cargo.toml b/bindings/rust/libgpiod-sys/Cargo.toml
> index 77f82719d269..af4098cb137d 100644
> --- a/bindings/rust/libgpiod-sys/Cargo.toml
> +++ b/bindings/rust/libgpiod-sys/Cargo.toml
> @@ -1,6 +1,11 @@
>  [package]
>  name = "libgpiod-sys"
>  version = "0.1.0"
> +authors = ["Viresh Kumar <viresh.kumar@linaro.org>"]
> +description = "A rust library for libgpiod public header bindings"
> +repository = "https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git/"
> +keywords = ["libgpiod", "gpio"]
> +license = "LGPL-2.1-or-later"
>  edition = "2018"
> 

Why the 2018 edition, rather than 2021?

> I picked license details from C code, is that what we should be using
> here too ?
> 

LGPL is probably not appropriate here, as the binding code ends up
being part of the binary - unless you plan to package it as a dynamic
library?

The licenses of your dependencies are:
$ cargo license
(MIT OR Apache-2.0) AND Unicode-DFS-2016 (1): unicode-ident
Apache-2.0 AND BSD-3-Clause (1): vmm-sys-util
Apache-2.0 OR MIT (8): bitflags, cc, libc, proc-macro2, quote, syn, thiserror, thiserror-impl
MIT (1): intmap
N/A (3): gpiosim, libgpiod, libgpiod-sys

IANAL, but one or more of those would be more appropriate than either
GPL or LGPL.
You, Bart and linaro(?) will have to come to some agreement on which
license or combination to go with - it depends.

Cheers,
Kent.