linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	linux-spi@vger.kernel.org, openbmc@lists.ozlabs.org,
	"Lee Jones" <lee@kernel.org>, "Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Mark Brown" <broonie@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH 3/8] dt-bindings: spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU)
Date: Mon, 7 Nov 2022 13:12:08 +0100	[thread overview]
Message-ID: <Y2j2GDKsvXwAdzg/@probook> (raw)
In-Reply-To: <2400e167-073e-65fa-7fe6-b64a34bce256@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]

On Mon, Nov 07, 2022 at 09:09:15AM +0100, Krzysztof Kozlowski wrote:
> On 06/11/2022 15:45, Jonathan Neuschäfer wrote:
> > On Sun, Nov 06, 2022 at 10:38:45AM +0100, Krzysztof Kozlowski wrote:
[...]
> >> This is rather obvious, so what you should comment is WHY or WHEN second
> >> resource can be omitted.
> > 
> > Ok, I'll add more reasoning, which is basically: The "memory" mapping is
> > only an optimization for faster access, knowledge of it is not necessary
> > for full operation of the device.
> > 
> >> Not every instance on the hardware has it?
> > 
> > AFAIK every instance has it, and there's unlikely to be any variation on
> > this fact anymore, because newer Nuvoton SoCs replaced the FIU with a
> > redesigned and incompatible version.
> > 
> > I admit that the value of making the "memory" mapping optional is rather
> > theoretical, and I'm open to making this reg item mandatory to simplify
> > the binding.
> 
> If every instance has it, then regardless whether it is actually used or
> not, just require second address?

Alright, I'll do that.

Thanks,
Jonathan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-11-07 12:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-05 18:59 [PATCH 0/8] Nuvoton WPCM450 FIU SPI flash controller Jonathan Neuschäfer
2022-11-05 18:59 ` [PATCH 1/8] pinctrl: nuvoton: wpcm450: Refactor MFSEL setting code Jonathan Neuschäfer
2022-11-05 18:59 ` [PATCH 2/8] pinctrl: nuvoton: wpcm450: Fix handling of inverted MFSEL bits Jonathan Neuschäfer
2022-11-05 18:59 ` [PATCH 3/8] dt-bindings: spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) Jonathan Neuschäfer
2022-11-06  9:38   ` Krzysztof Kozlowski
2022-11-06 14:45     ` Jonathan Neuschäfer
2022-11-07  8:09       ` Krzysztof Kozlowski
2022-11-07 12:12         ` Jonathan Neuschäfer [this message]
2022-11-06 13:27   ` Rob Herring
2022-11-05 18:59 ` [PATCH 4/8] dt-bindings: mfd: syscon: Add nuvoton,wpcm450-shm Jonathan Neuschäfer
2022-11-06  9:39   ` Krzysztof Kozlowski
2022-11-07  9:20   ` Lee Jones
2022-11-05 18:59 ` [PATCH 5/8] ARM: dts: wpcm450: Add FIU SPI controller node Jonathan Neuschäfer
2022-11-05 18:59 ` [PATCH 6/8] ARM: dts: wpcm450-supermicro-x9sci-ln4f: Add SPI flash Jonathan Neuschäfer
2022-11-05 18:59 ` [PATCH 7/8] spi: wpcm-fiu: Add driver for Nuvoton WPCM450 Flash Interface Unit (FIU) Jonathan Neuschäfer
2022-11-05 21:35   ` kernel test robot
2022-11-06 14:51     ` Jonathan Neuschäfer
2022-11-05 21:45   ` kernel test robot
2022-11-05 18:59 ` [PATCH 8/8] spi: wpcm-fiu: Add direct map support Jonathan Neuschäfer
2022-11-05 21:35   ` kernel test robot
2022-11-06 14:49     ` Jonathan Neuschäfer
2022-11-09  8:41 ` [PATCH 0/8] Nuvoton WPCM450 FIU SPI flash controller Linus Walleij
2022-11-09 10:08   ` Jonathan Neuschäfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2j2GDKsvXwAdzg/@probook \
    --to=j.neuschaefer@gmx.net \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).