From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34034C43219 for ; Tue, 8 Nov 2022 22:10:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229670AbiKHWJ6 (ORCPT ); Tue, 8 Nov 2022 17:09:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229639AbiKHWJy (ORCPT ); Tue, 8 Nov 2022 17:09:54 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5FFA5F860; Tue, 8 Nov 2022 14:09:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cCKHxPK11Q1jukKuWDcpKP+n2x8r5Bmc1C1fASXO8NQ=; b=EU0HS7ZSrrjOMX8APCRZwMm6WL D8irO/yPwhMriOwK6AlOa/byzotS3WboDQ+XnuvJj43Ueswc7R0wKRFtbqYX64n9dnWcqZyHnmfq/ 5EoQegbzK9uurHr9gQ5SJIBey94pJ4gzQ/nNwP0SnNHBwdCxArlNgkARgknSYEsPZWH8/AO+xhaQ5 PFduDLegjqsp4ejFbTCK3en04HfLxq0KTjoRskd38CCMKV6sT7w85uaBfVutlN+rTv0ugEuObQLRV yDWUWkFmtn4xx/MNODHb7TYYyB/CtlkadWqniPmY4LquuVMvnTPWbUpP66u4orCZ+BDznbeamFs4k m9Cn2Cow==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35180) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1osWmm-0003nG-HU; Tue, 08 Nov 2022 22:09:36 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1osWmf-00055o-W6; Tue, 08 Nov 2022 22:09:30 +0000 Date: Tue, 8 Nov 2022 22:09:29 +0000 From: "Russell King (Oracle)" To: Krzysztof Kozlowski Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Lee Jones , Alyssa Rosenzweig , Andy Shevchenko , asahi@lists.linux.dev, devicetree@vger.kernel.org, Hector Martin , Jonathan Corbet , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, Petr Mladek , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Sven Peter Subject: Re: [PATCH v3 6/7] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC Message-ID: References: <3d51c0e2-1e59-5767-4be1-5754ca8dc902@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d51c0e2-1e59-5767-4be1-5754ca8dc902@linaro.org> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Nov 08, 2022 at 09:56:40PM +0100, Krzysztof Kozlowski wrote: > On 08/11/2022 17:33, Russell King (Oracle) wrote: > > Add the DT binding for the Apple Mac System Management Controller GPIOs. > > > > Signed-off-by: Russell King (Oracle) > > --- > > .../bindings/gpio/apple,smc-gpio.yaml | 37 +++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml > > > > diff --git a/Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml b/Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml > > new file mode 100644 > > index 000000000000..1a415b78760b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml > > @@ -0,0 +1,37 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml# > > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). Oh ffs. DT bindings are utterly impossible to get correct. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!