Re: [PATCH v3 4/7] gpio: tps6594x: add GPIO support for TPS6594x PMIC

[Matt Ranostay <mranostay@ti.com>]

On Wed, Nov 09, 2022 at 10:59:08AM +0100, Linus Walleij wrote:
> On Wed, Nov 9, 2022 at 7:56 AM Matt Ranostay <mranostay@ti.com> wrote:
> 
> > Add support for TPS6594X PMICs GPIO interface that has 11 that can be
> > configured as input or outputs.
> >
> > Tested-by: Keerthy <j-keerthy@ti.com>
> > Signed-off-by: Matt Ranostay <mranostay@ti.com>
> 
> (...)
> > +config GPIO_TPS6594X
> > +       tristate "TI TPS6594X GPIO driver"
> > +       depends on MFD_TPS6594X
> > +       help
> > +         Select this option to enable GPIO driver for the TPS6954X
> > +         PMIC chip family. There are 11 GPIOs that can be configured.
> 
> select GPIO_REGMAP
> 
> This driver is an archetypical example of a driver that can make great
> use of GPIO_REGMAP helpers, so rewrite it to use them.
> Look in drivers/gpio/gpio-sl28cpld.c for an example.

Linus,

Those helpers look great for this usecase on the surface but however I think there could be some issues.
For GPIO direction it isn't configured by a bitmap on a register(s) but by a bit on a range of
registers (with a register for each GPIOx).

For set/get values the gpio helper would work though.

- Matt

> 
> Yours,
> Linus Walleij