From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF661C4332F for ; Thu, 10 Nov 2022 11:48:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230366AbiKJLsl (ORCPT ); Thu, 10 Nov 2022 06:48:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbiKJLsj (ORCPT ); Thu, 10 Nov 2022 06:48:39 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD67225DD; Thu, 10 Nov 2022 03:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yICizhPaPAd6Anz2X8tzuaaxbrcs/SbK9IONa0om9nk=; b=gSqx6CLUDvVcRMfUg6c4zh7xV2 espdRU6Vp+vyqM1801RhQc6guUO7pxmgfw/etSRjp2yEGeuwdTGHauTquQ2KEjoFrUR3CTBZdsvy9 ta2DgiWYE1YEGrRTUHHu0YJ8GJGhik5VAxygWrHbJumPKjYY3VKKX+EzVkQKmG4Sy0jp//jMzSnD2 tp08Fme6jlriV9llNihpKQO6ww3TYm22Ho5TUKEZuDLXvnCIlNuUY+GiqOLwrY1ugn1rhe1mj7jgx Q1IUsCtyYrknptv0/rwtOpigIircVPUHqjVqhG4fAWqQMdhAFW5dpB//7AUedLXYlfSd4OFcRR+lk KShPLqdg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35198) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ot62j-0005ZJ-4F; Thu, 10 Nov 2022 11:48:25 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ot62d-0006cL-MZ; Thu, 10 Nov 2022 11:48:19 +0000 Date: Thu, 10 Nov 2022 11:48:19 +0000 From: "Russell King (Oracle)" To: Rob Herring Cc: Krzysztof Kozlowski , Linus Walleij , Bartosz Golaszewski , Lee Jones , Alyssa Rosenzweig , Andy Shevchenko , asahi@lists.linux.dev, devicetree@vger.kernel.org, Hector Martin , Jonathan Corbet , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, Petr Mladek , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Sven Peter Subject: Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller Message-ID: References: <531d88b8-75db-1d8f-1384-b8d05594e7b3@linaro.org> <20221109221723.GA2948356-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221109221723.GA2948356-robh@kernel.org> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Nov 09, 2022 at 04:17:23PM -0600, Rob Herring wrote: > On Tue, Nov 08, 2022 at 10:22:31PM +0000, Russell King (Oracle) wrote: > > On Tue, Nov 08, 2022 at 09:55:58PM +0100, Krzysztof Kozlowski wrote: > > > On 08/11/2022 17:33, Russell King (Oracle) wrote: > > > > Add a DT binding for the Apple Mac System Management Controller. > > > > > > Drop the second, redundant "binding" from subject. It's already in prefix. > > > > Yet another thing that's been there from the start... how many more > > things are you going to pick up in subsequent versions of the patch? > > When does this stop? > > > > In any case, taking your comment literally, > > > > "dt-bindings: mfd: add for Apple Mac System Management Controller" > > > > makes no sense, so presumably you want something more than that. > > > > In any case, I see several recent cases already merged which follow > > the pattern that I've used and that you've reviewed. > > > > > > Signed-off-by: Russell King (Oracle) > > > > --- > > > > .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ > > > > 1 file changed, 67 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/apple,smc.yaml b/Documentation/devicetree/bindings/mfd/apple,smc.yaml > > > > new file mode 100644 > > > > index 000000000000..014eba5a1bbc > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/mfd/apple,smc.yaml > > > > @@ -0,0 +1,67 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Apple Mac System Management Controller > > > > + > > > > +maintainers: > > > > + - Hector Martin > > > > + > > > > +description: > > > > + Apple Mac System Management Controller implements various functions > > > > + such as GPIO, RTC, power, reboot. > > > > + > > > > +properties: > > > > + compatible: > > > > + items: > > > > + - enum: > > > > + - apple,t6000-smc > > > > + - apple,t8103-smc > > > > + - apple,t8112-smc > > > > + - const: apple,smc > > > > + > > > > + reg: > > > > + items: > > > > + - description: SMC area > > > > + - description: SRAM area > > > > + > > > > + reg-names: > > > > + items: > > > > + - const: smc > > > > + - const: sram > > > > + > > > > + mboxes: > > > > + maxItems: 1 > > > > + > > > > + gpio: > > > > + $ref: /schemas/gpio/gpio-macsmc.yaml > > > > > > So this depends on other patch, so: > > > 1. You need mention the dependency in cover letter (nothing there), > > > 2. Re-order patches. > > > > > > The GPIO cannot go separate tree and this must be explicitly communicated. > > > > Sigh, getting an order that is sensible is really bloody difficult. > > It's not. Sub-devices before the MFD. The only time that doesn't work is > when the sub-devices put the parent MFD in their example. The solution > there is don't do that. Just 1 complete example in the MFD schema and no > examples in the sub-devices. Meanwhile, I was told by Krzysztof that DT schemas must always have an example. So, different person, different story. Anyway, I've washed my hands of this farce with this series. I'm not planning to post another version of it. I've had enough of this crap. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!