From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0222DC433FE for ; Wed, 16 Nov 2022 01:12:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231470AbiKPBML (ORCPT ); Tue, 15 Nov 2022 20:12:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231590AbiKPBMK (ORCPT ); Tue, 15 Nov 2022 20:12:10 -0500 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED0513137B for ; Tue, 15 Nov 2022 17:12:09 -0800 (PST) Received: by mail-pf1-x433.google.com with SMTP id 140so14557496pfz.6 for ; Tue, 15 Nov 2022 17:12:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0It5KbZc0A7Bzf8S3NgAg+pHebZzRFuPQgku3idwdPA=; b=FNkaFNP4D46TTgKlgZ16J2A7fOlsLDhhQ5d5esrYuviXjwHweOcodLVREPJAU7gSAU XM6AvBnZ/6ZjpjLgfJEjO2X/KjUR84+a+62msQT++ToRPykjg9msaL36/9QxiREMGOma Ykd68p6E6U8NZXCkVeIIT2Aqn8OZSVYrJlPXmIoRgdzrjS7h3amVG41j79nrENRWvOxx WC+XzxF3MhudltrbmetzchWZzqLijqqCiZteL7mTRbtNa/yXnjjcPOz+pJ45lohHmYUw JLbDAo2d4PNBFF6qfRTYgRH0E0f/Sa6zr8qtvLFD1ekcnRCcJEn+EwJsP4aQVN4vPwCz x0mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0It5KbZc0A7Bzf8S3NgAg+pHebZzRFuPQgku3idwdPA=; b=CneIodlHyqar1oq7TkaNa97Du8i9C6VMWmYebhVzEevxABBP8tzx9XqMNAL4VR/UpZ SOKybvd9EPxMQCT3lKZn567wsDbCuexzWF3ETQxfDJSrgy5l3Oa6G2rS5/P+TKIAaD46 bdYy5+QKpptqTdCOOUi6cUUGo5hGYOjybdeazAp3o42F51SmWTbYE+PmbiOwqNn2a3CX pI2xUMldciZ7s/hyUHvWJYr4/DjPQYJjNHd11cyPrYATCRTazNqNIET4WTRkwn108vsZ 8cSceQi2aKzPxrrH+DtT5WhgDQecWveUdCFX8TrA4eU8ZY+fXaVnzYAS4mTbmGH61V1s y0ag== X-Gm-Message-State: ANoB5pmXoQCoP0qP93dSAw2hZTjeE1Sa7ilBsrYWFP02ZiJOmX6YU9gA hCJ0sg+lD5w7KNiu+TnMNXvZs9093j8= X-Google-Smtp-Source: AA0mqf4KmbfyS8ljyMDTJHdmc2qz+u0FgDzuHImU4C6+TSTCpaNvGj8IjqKEZtNqsTuuVKPeEXBcuQ== X-Received: by 2002:a63:db13:0:b0:46f:8e43:e966 with SMTP id e19-20020a63db13000000b0046f8e43e966mr17936799pgg.206.1668561129485; Tue, 15 Nov 2022 17:12:09 -0800 (PST) Received: from sol (14-200-229-209.tpgi.com.au. [14.200.229.209]) by smtp.gmail.com with ESMTPSA id w36-20020a17090a6ba700b0020adf65cebbsm210795pjj.8.2022.11.15.17.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 17:12:08 -0800 (PST) Date: Wed, 16 Nov 2022 09:12:01 +0800 From: Kent Gibson To: Bartosz Golaszewski Cc: Viresh Kumar , Linus Walleij , Vincent Guittot , linux-gpio@vger.kernel.org, Miguel Ojeda , Wedson Almeida Filho , Alex =?iso-8859-1?Q?Benn=E9e?= , stratos-dev@op-lists.linaro.org, Gerard Ryan , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , y86-dev Subject: Re: [libgpiod][PATCH V9 0/8] libgpiod: Add Rust bindings Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Nov 14, 2022 at 10:49:36PM +0100, Bartosz Golaszewski wrote: > On Mon, Nov 7, 2022 at 10:57 AM Viresh Kumar wrote: > > > > Hello, > > > > Here is another version of the rust bindings, based of the master branch. > > > > Pushed here: > > > > https://github.com/vireshk/libgpiod v9 > > > > V8->V9: > > - Merged the last patch (supporting Events) with the other patches. > > - Events implementation is simplified and made efficient. nth() is also > > implemented for the iterator. > > - Unnecessary comment removed from Cargo.toml files. > > - Updated categories in libgpiod's Cargo.toml. > > - Updated gpio_events example to show cloned events live past another > > read_edge_events(). > > - Implement AsRawFd for Chip. > > - Other minor changes. > > > > Kent, Miguel: if you are ok with this version - can you add your review tags? > > Bart As mentioned elsewhere, I'm a bit iffy about the handling of non-UTF-8 names, which are treated as errors, but are valid in the C API. But that is an extreme corner case that can be addressed later, so I have no objection to this version being merged. Reviewed-by: Kent Gibson Cheers, Kent.