From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Niyas Sait <niyas.sait@linaro.org>,
linux-gpio@vger.kernel.org, mika.westerberg@linux.intel.com,
rafael@kernel.org
Subject: Re: [PATCH RFC v2 2/3] pinconf-generic: clarify pull up and pull down config values
Date: Thu, 17 Nov 2022 12:39:29 +0200 [thread overview]
Message-ID: <Y3YPYT8HkEFF1hJw@smile.fi.intel.com> (raw)
In-Reply-To: <Y3YO+F03Hgu7KVRU@smile.fi.intel.com>
On Thu, Nov 17, 2022 at 12:37:44PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 17, 2022 at 10:30:37AM +0100, Linus Walleij wrote:
> > On Tue, Nov 15, 2022 at 6:54 PM Niyas Sait <niyas.sait@linaro.org> wrote:
> >
> > > PIN_CONFIG_BIAS_PULL_DOWN and PIN_CONFIG_BIAS_PULL_UP values can
> > > be custom or an SI unit such as ohms
> > >
> > > Signed-off-by: Niyas Sait <niyas.sait@linaro.org>
> >
> > This patch is good as-is so I just applied it. No need to resend with
> > the ACPI series.
>
> Is it? I think it's visible that it has TAB vs. space issue...
To be more clear, the "such as ohms" have been indented with spaces, while
everything else with TABs. On top of that I would use proper capitalization
for unit, i.e. Ohms. But the latter is minor.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-17 10:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 17:54 [PATCH RFC v2 0/3] pinctrl: add ACPI support to pin controller Niyas Sait
2022-11-15 17:54 ` [PATCH RFC v2 1/3] pinctrl: add support for ACPI PinGroup resource Niyas Sait
2022-11-16 9:41 ` Mika Westerberg
2022-11-17 13:28 ` Niyas Sait
2022-11-17 15:08 ` Mika Westerberg
2022-11-15 17:54 ` [PATCH RFC v2 2/3] pinconf-generic: clarify pull up and pull down config values Niyas Sait
2022-11-17 9:30 ` Linus Walleij
2022-11-17 10:37 ` Andy Shevchenko
2022-11-17 10:39 ` Andy Shevchenko [this message]
2022-11-17 11:53 ` Niyas Sait
2022-11-17 12:36 ` Andy Shevchenko
2022-11-15 17:54 ` [PATCH RFC v2 3/3] pinctrl: add support for ACPI pin function and config resources Niyas Sait
2022-11-16 9:57 ` Mika Westerberg
2022-11-15 18:12 ` [PATCH RFC v2 0/3] pinctrl: add ACPI support to pin controller Andy Shevchenko
2022-11-15 18:29 ` Niyas Sait
2022-11-15 18:47 ` Andy Shevchenko
2022-11-15 19:15 ` Niyas Sait
2022-11-16 10:16 ` Andy Shevchenko
2022-11-16 10:27 ` Niyas Sait
2022-11-16 9:50 ` Niyas Sait
2022-11-16 9:56 ` Andy Shevchenko
2022-11-16 10:40 ` Niyas Sait
2022-11-16 13:27 ` Andy Shevchenko
2022-11-16 13:38 ` Andy Shevchenko
2022-11-16 10:17 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3YPYT8HkEFF1hJw@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=niyas.sait@linaro.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).