From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C49C433FE for ; Fri, 18 Nov 2022 12:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235025AbiKRMwz (ORCPT ); Fri, 18 Nov 2022 07:52:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbiKRMwy (ORCPT ); Fri, 18 Nov 2022 07:52:54 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6F37A1AF09; Fri, 18 Nov 2022 04:52:51 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id C0373807E; Fri, 18 Nov 2022 12:42:44 +0000 (UTC) Date: Fri, 18 Nov 2022 14:52:49 +0200 From: Tony Lindgren To: Maxim Korotkov Cc: Haojian Zhuang , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] pinctrl: single: fix potential NULL dereference Message-ID: References: <20221118104332.943-1-korotkov.maxim.s@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221118104332.943-1-korotkov.maxim.s@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org * Maxim Korotkov [221118 10:33]: > Added checking of pointer "function" in pcs_set_mux(). > pinmux_generic_get_function() can return NULL and the pointer > "function" was dereferenced without checking against NULL. Reviewed-by: Tony Lindgren