From: Kent Gibson <warthog618@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Bartosz Golaszewski" <brgl@bgdev.pl>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
linux-gpio@vger.kernel.org,
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
stratos-dev@op-lists.linaro.org,
"Gerard Ryan" <g.m0n3y.2503@gmail.com>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
y86-dev <y86-dev@protonmail.com>
Subject: Re: [libgpiod][PATCH V10 2/6] bindings: rust: Add libgpiod crate
Date: Tue, 22 Nov 2022 13:30:22 +0800 [thread overview]
Message-ID: <Y3xebr68RT7JvLDJ@sol> (raw)
In-Reply-To: <20221122051541.j54z6ix6ojhzilut@vireshk-i7>
On Tue, Nov 22, 2022 at 10:45:41AM +0530, Viresh Kumar wrote:
> On 22-11-22, 13:09, Kent Gibson wrote:
> > Which is a library that reads the envvars set by Cargo at compile time,
> > so you could also just
> >
> > const VERSION: &'static str = env!("CARGO_PKG_VERSION");
> >
> > and provide a function that returns that.
>
> Right, this is what we are doing currently:
>
> /// Get the API version of the libgpiod crate as a human-readable string.
> pub fn crate_version() -> &'static str {
> env!("CARGO_PKG_VERSION")
> }
>
Which is already the standard way, so not sure how the discussion took
the path it did, but anyway...
It is safe to assume the libgpiod-sys version is tied to the libgpiod
crate version?
Cheers,
Kent.
next prev parent reply other threads:[~2022-11-22 5:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 10:44 [libgpiod][PATCH V10 0/6] libgpiod: Add Rust bindings Viresh Kumar
2022-11-18 10:44 ` [libgpiod][PATCH V10 1/6] bindings: rust: Add libgpiod-sys rust crate Viresh Kumar
2022-11-18 10:44 ` [libgpiod][PATCH V10 2/6] bindings: rust: Add libgpiod crate Viresh Kumar
2022-11-21 14:12 ` Bartosz Golaszewski
2022-11-22 4:38 ` Viresh Kumar
2022-11-22 5:09 ` Kent Gibson
2022-11-22 5:15 ` Viresh Kumar
2022-11-22 5:30 ` Kent Gibson [this message]
2022-11-22 5:35 ` Viresh Kumar
2022-11-18 10:44 ` [libgpiod][PATCH V10 3/6] bindings: rust: Add gpiosim-sys crate Viresh Kumar
2022-11-18 10:44 ` [libgpiod][PATCH V10 4/6] bindings: rust: Add examples to libgpiod crate Viresh Kumar
2022-11-18 10:44 ` [libgpiod][PATCH V10 5/6] bindings: rust: Add tests for " Viresh Kumar
2022-11-18 10:44 ` [libgpiod][PATCH V10 6/6] bindings: rust: Integrate building of bindings with make Viresh Kumar
2022-11-21 13:46 ` [libgpiod][PATCH V10 0/6] libgpiod: Add Rust bindings Linus Walleij
2022-11-21 20:22 ` Bartosz Golaszewski
2022-11-22 4:27 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3xebr68RT7JvLDJ@sol \
--to=warthog618@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=alex.gaynor@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=brgl@bgdev.pl \
--cc=g.m0n3y.2503@gmail.com \
--cc=gary@garyguo.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=stratos-dev@op-lists.linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=wedsonaf@gmail.com \
--cc=y86-dev@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).