linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-gpio@vger.kernel.org
Subject: Re: [libgpiod][PATCH] tools: gpioset: remove pointless whitespace
Date: Wed, 7 Dec 2022 18:25:18 +0800	[thread overview]
Message-ID: <Y5BqDnIG6avgckW2@sol> (raw)
In-Reply-To: <CAMRc=Mf1JjryzGY6zYoUY+a_BSrU81TWfJS1EHrof4pEFvv6Jw@mail.gmail.com>

On Wed, Dec 07, 2022 at 11:16:19AM +0100, Bartosz Golaszewski wrote:
> On Wed, Dec 7, 2022 at 10:39 AM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > Remove pointless whitespace in interact().
> >
> > Signed-off-by: Kent Gibson <warthog618@gmail.com>
> > ---
> >  tools/gpioset.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/tools/gpioset.c b/tools/gpioset.c
> > index c49d229..68b3922 100644
> > --- a/tools/gpioset.c
> > +++ b/tools/gpioset.c
> > @@ -842,8 +842,7 @@ static void interact(struct gpiod_line_request **requests,
> >                 }
> >
> >                 printf("unknown command: '%s'\n", words[0]);
> > -               printf("Try the 'help' command\n")
> > -                       ;
> > +               printf("Try the 'help' command\n");
> >
> >  cmd_ok:
> >                 for (i = 0; isspace(line[i]); i++)
> > --
> > 2.38.1
> >
> 
> I've already fixed that automatically with my clang-format sweep of
> the tree, thanks!
> 

Haha, so you have. Nice.

Cheers,
Kent.

      reply	other threads:[~2022-12-07 10:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-07  9:39 [libgpiod][PATCH] tools: gpioset: remove pointless whitespace Kent Gibson
2022-12-07 10:16 ` Bartosz Golaszewski
2022-12-07 10:25   ` Kent Gibson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5BqDnIG6avgckW2@sol \
    --to=warthog618@gmail.com \
    --cc=brgl@bgdev.pl \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).